Skip to content

Commit aeb11ab

Browse files
committed
Fix test
1 parent aa25150 commit aeb11ab

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3223,7 +3223,7 @@ public void testOutOfOrderDeletePersistenceIntoLedgerWithClose() throws Exceptio
32233223
managedLedgerConfig.setMaxUnackedRangesToPersistInMetadataStore(10);
32243224
ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory.open(ledgerName, managedLedgerConfig);
32253225

3226-
ManagedCursorImpl c1 = (ManagedCursorImpl) ledger.openCursor(cursorName);
3226+
final ManagedCursorImpl c1 = (ManagedCursorImpl) ledger.openCursor(cursorName);
32273227

32283228
List<Position> addedPositions = new ArrayList<>();
32293229
for (int i = 0; i < totalAddEntries; i++) {
@@ -3269,7 +3269,8 @@ public void operationFailed(MetaStoreException e) {
32693269
LedgerEntry entry = seq.nextElement();
32703270
PositionInfo positionInfo;
32713271
positionInfo = PositionInfo.parseFrom(entry.getEntry());
3272-
individualDeletedMessagesCount.set(positionInfo.getIndividualDeletedMessagesCount());
3272+
c1.recoverIndividualDeletedMessages(positionInfo);
3273+
individualDeletedMessagesCount.set(c1.getIndividuallyDeletedMessagesSet().asRanges().size());
32733274
} catch (Exception e) {
32743275
}
32753276
latch.countDown();
@@ -3286,12 +3287,12 @@ public void operationFailed(MetaStoreException e) {
32863287
@Cleanup("shutdown")
32873288
ManagedLedgerFactory factory2 = new ManagedLedgerFactoryImpl(metadataStore, bkc);
32883289
ledger = (ManagedLedgerImpl) factory2.open(ledgerName, managedLedgerConfig);
3289-
c1 = (ManagedCursorImpl) ledger.openCursor("c1");
3290+
ManagedCursorImpl reopenCursor = (ManagedCursorImpl) ledger.openCursor("c1");
32903291
// verify cursor has been recovered
3291-
assertEquals(c1.getNumberOfEntriesInBacklog(false), totalAddEntries / 2);
3292+
assertEquals(reopenCursor.getNumberOfEntriesInBacklog(false), totalAddEntries / 2);
32923293

32933294
// try to read entries which should only read non-deleted positions
3294-
List<Entry> entries = c1.readEntries(totalAddEntries);
3295+
List<Entry> entries = reopenCursor.readEntries(totalAddEntries);
32953296
assertEquals(entries.size(), totalAddEntries / 2);
32963297
}
32973298

managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerBkTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,6 @@ public void testUnackmessagesAndRecovery() throws Exception {
600600
ManagedLedgerFactoryConfig factoryConf = new ManagedLedgerFactoryConfig();
601601
factoryConf.setMaxCacheSize(0);
602602

603-
@Cleanup("shutdown")
604603
ManagedLedgerFactory factory = new ManagedLedgerFactoryImpl(metadataStore, bkc, factoryConf);
605604

606605
ManagedLedgerConfig config = new ManagedLedgerConfig().setEnsembleSize(1).setWriteQuorumSize(1)
@@ -619,8 +618,6 @@ public void testUnackmessagesAndRecovery() throws Exception {
619618

620619
LongPairRangeSet<Position> unackMessagesBefore = cursor.getIndividuallyDeletedMessagesSet();
621620

622-
// close cursor
623-
cursor.close();
624621
ledger.close();
625622

626623
// open and recover cursor
@@ -631,5 +628,6 @@ public void testUnackmessagesAndRecovery() throws Exception {
631628
assertTrue(unackMessagesBefore.equals(unackMessagesAfter));
632629

633630
ledger.close();
631+
factory.shutdown();
634632
}
635633
}

0 commit comments

Comments
 (0)