Commit 4297661
authored
[ZEPPELIN-6308] Extract hardcoded py4j values to constants
### What is this PR for?
This PR extracts hardcoded py4j values to constants in Python interpreters to improve maintainability. It creates a new PythonConstants class to centralize py4j version and file path constants, replacing hardcoded strings across multiple Python interpreter classes. This addresses the TODO comment requesting to avoid hardcoded py4j values.
### What type of PR is it?
Refactoring
### Todos
* [x] - Create PythonConstants class with py4j constants
* [x] - Replace hardcoded py4j values in IPythonInterpreter
* [x] - Replace hardcoded py4j values in PythonInterpreter
* [x] - Replace hardcoded py4j values in PythonDockerInterpreter
### What is the Jira issue?
[ZEPPELIN-6308](https://issues.apache.org/jira/browse/ZEPPELIN-6308)
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Closes #5056 from celinayk/ZEPPELIN-6308.
Signed-off-by: ParkGyeongTae <gyeongtae@apache.org>1 parent 85b7550 commit 4297661
File tree
4 files changed
+44
-6
lines changed- python/src/main/java/org/apache/zeppelin/python
4 files changed
+44
-6
lines changedLines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
181 | | - | |
182 | | - | |
| 181 | + | |
183 | 182 | | |
184 | | - | |
| 183 | + | |
185 | 184 | | |
186 | 185 | | |
187 | 186 | | |
| |||
Lines changed: 34 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
190 | 193 | | |
191 | 194 | | |
192 | 195 | | |
| |||
212 | 215 | | |
213 | 216 | | |
214 | 217 | | |
215 | | - | |
| 218 | + | |
| 219 | + | |
216 | 220 | | |
217 | 221 | | |
218 | 222 | | |
| |||
0 commit comments