change CommandExecutor logic for return result

Author: apacheborys

src/BasicExecutor/CommandExecutor.php

@@ -6,6 +6,7 @@
 use ApacheBorys\Retry\Entity\Config;
 use ApacheBorys\Retry\Entity\Message;
 use ApacheBorys\Retry\Interfaces\Executor;
+use Psr\Log\LoggerInterface;
 
 class CommandExecutor implements Executor
 {
@@ -16,19 +17,26 @@ class CommandExecutor implements Executor
     private array $environmentVars;
     private ?string $cwd;
     private ?array $envVariablesSnapshot = null;
+    private ?LoggerInterface $logger;
 
     /**
      * @param string $commandAddress                    First operand after php
      * @param array<string, string> $arguments          Array of arguments. Key - argument name, value - regular expression for error message
      * @param string|null $cwd                          The initial working dir for the command
      * @param array<String, String> $environmentVars    Set of env variables to execute command. It will be set before execution and rolled back after
      */
-    public function __construct(string $commandAddress, array $arguments = [], ?string $cwd = null, array $environmentVars = [])
-    {
+    public function __construct(
+        string $commandAddress,
+        array $arguments = [],
+        ?string $cwd = null,
+        array $environmentVars = [],
+        ?LoggerInterface $logger = null
+    ) {
         $this->commandAddress = $commandAddress;
         $this->arguments = $arguments;
         $this->cwd = $cwd;
         $this->environmentVars = $environmentVars;
+        $this->logger = $logger;
     }
 
     public function handle(Message $message): bool
@@ -66,17 +74,25 @@ public function handle(Message $message): bool
                 sleep(1);
             }
 
-            $returnValue = proc_close($process);
+            proc_close($process);
         } catch (\Throwable $e) {
             $this->rollbackEnvironmentVariables();
+            if ($this->logger) {
+                $this->logger->debug(
+                    sprintf(
+                        'Command executor in Retry library catch exception during execution of command. Error: %s',
+                        $e->getMessage()
+                    )
+                );
+            }
 
-            throw $e;
+            return false;
         }
 
         $this->rollbackEnvironmentVariables();
         putenv(self::ALIAS_FOR_CORRELATION_ID);
 
-        return $returnValue !== -1;
+        return true;
     }
 
     public function compilePayload(\Throwable $exception, Config $config): array