Skip to content

Commit f2f0ca7

Browse files
committed
Revert "feat: log the actor permission on actor initialization"
This reverts commit 2457458.
1 parent 2457458 commit f2f0ca7

File tree

2 files changed

+35
-47
lines changed

2 files changed

+35
-47
lines changed

src/apify/_actor.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,14 +192,6 @@ async def __aenter__(self) -> Self:
192192

193193
# Mark initialization as complete and update global state.
194194
self._is_initialized = True
195-
196-
self.log.info(
197-
'Permissions',
198-
extra={
199-
'actor_permission_level': self.get_env().get('actor_permission_level'),
200-
},
201-
)
202-
203195
return self
204196

205197
async def __aexit__(

tests/unit/actor/test_actor_log.py

Lines changed: 35 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ async def test_actor_logs_messages_correctly(caplog: pytest.LogCaptureFixture) -
3939
records = caplog.records
4040

4141
# Expected number of log records
42-
assert len(records) == 14
42+
assert len(records) == 13
4343

4444
# Record 0: Initializing Actor
4545
assert records[0].levelno == logging.INFO
@@ -61,46 +61,42 @@ async def test_actor_logs_messages_correctly(caplog: pytest.LogCaptureFixture) -
6161
assert records[4].levelno == logging.DEBUG
6262
assert records[4].message == 'Charging manager initialized'
6363

64-
# Record 5: Actor Permissions
65-
assert records[5].levelno == logging.INFO
66-
assert records[5].message == 'Permissions'
64+
# Record 5: Debug message
65+
assert records[5].levelno == logging.DEBUG
66+
assert records[5].message == 'Debug message'
6767

68-
# Record 6: Debug message
69-
assert records[6].levelno == logging.DEBUG
70-
assert records[6].message == 'Debug message'
68+
# Record 6: Info message
69+
assert records[6].levelno == logging.INFO
70+
assert records[6].message == 'Info message'
7171

72-
# Record 7: Info message
73-
assert records[7].levelno == logging.INFO
74-
assert records[7].message == 'Info message'
72+
# Record 7: Warning message
73+
assert records[7].levelno == logging.WARNING
74+
assert records[7].message == 'Warning message'
7575

76-
# Record 8: Warning message
77-
assert records[8].levelno == logging.WARNING
78-
assert records[8].message == 'Warning message'
76+
# Record 8: Error message
77+
assert records[8].levelno == logging.ERROR
78+
assert records[8].message == 'Error message'
7979

80-
# Record 9: Error message
80+
# Record 9: Exception message with traceback (ValueError)
8181
assert records[9].levelno == logging.ERROR
82-
assert records[9].message == 'Error message'
83-
84-
# Record 10: Exception message with traceback (ValueError)
85-
assert records[10].levelno == logging.ERROR
86-
assert records[10].message == 'Exception message'
87-
assert records[10].exc_info is not None
88-
assert records[10].exc_info[0] is ValueError
89-
assert isinstance(records[10].exc_info[1], ValueError)
90-
assert str(records[10].exc_info[1]) == 'Dummy ValueError'
91-
92-
# Record 11: Multiline log message
93-
assert records[11].levelno == logging.INFO
94-
assert records[11].message == 'Multi\nline\nlog\nmessage'
95-
96-
# Record 12: Actor failed with an exception (RuntimeError)
97-
assert records[12].levelno == logging.ERROR
98-
assert records[12].message == 'Actor failed with an exception'
99-
assert records[12].exc_info is not None
100-
assert records[12].exc_info[0] is RuntimeError
101-
assert isinstance(records[12].exc_info[1], RuntimeError)
102-
assert str(records[12].exc_info[1]) == 'Dummy RuntimeError'
103-
104-
# Record 13: Exiting Actor
105-
assert records[13].levelno == logging.INFO
106-
assert records[13].message == 'Exiting Actor'
82+
assert records[9].message == 'Exception message'
83+
assert records[9].exc_info is not None
84+
assert records[9].exc_info[0] is ValueError
85+
assert isinstance(records[9].exc_info[1], ValueError)
86+
assert str(records[9].exc_info[1]) == 'Dummy ValueError'
87+
88+
# Record 10: Multiline log message
89+
assert records[10].levelno == logging.INFO
90+
assert records[10].message == 'Multi\nline\nlog\nmessage'
91+
92+
# Record 11: Actor failed with an exception (RuntimeError)
93+
assert records[11].levelno == logging.ERROR
94+
assert records[11].message == 'Actor failed with an exception'
95+
assert records[11].exc_info is not None
96+
assert records[11].exc_info[0] is RuntimeError
97+
assert isinstance(records[11].exc_info[1], RuntimeError)
98+
assert str(records[11].exc_info[1]) == 'Dummy RuntimeError'
99+
100+
# Record 12: Exiting Actor
101+
assert records[12].levelno == logging.INFO
102+
assert records[12].message == 'Exiting Actor'

0 commit comments

Comments
 (0)