Agent activity timer keeps running after stream error or cancellation

[harz05]

Follow-up to #475.

Description

When a chat message results in a server error or is cancelled mid-stream, the "Agent Activity" timer in the trace header keeps counting up indefinitely. It never stops, even after the error message is rendered and the stream is done.

Steps to reproduce

1. Set a bad/fake API key via the API Keys tab (restored in fix api keys tab in chat settings #475)
2. Send a chat message
3. Observe the Agent Activity timer on the response, it runs forever

It should be noted that, I observed this issue after the fix for #475.

Expected behavior

Timer should stop and freeze at the elapsed time as soon as the stream ends, whether by final event, error event, cancelled event, or an exception (abort/timeout).

[AntuBattle]

Has anyone been working on this yet? If not, I can go ahead and fix it on my fork and then PR if it's ok.

[harz05]

Hi @AntuBattle since this is a follow up to #475 and I got this issue after fixing that, I think it'd be better that we work on this once the maintainers review the other PR.

[AntuBattle]

Hi @harz05 I got the issue by simply running the service without any changes, after cloning from main branch. I believe this is not dependent on your fix. However, let's wait for the maintainers to review.

[harz05]

Thanks @AntuBattle for letting me know about this, I think raising a PR should be fine then.

Tagging @lucalavezzo to maybe review this once.