Skip to content

Commit b9721b5

Browse files
committed
Define macOS code signing identity via AC_APPLICATION_IDENTITY environment variable
The release workflows use the "Gon" tool to sign and notarize the macOS builds. The signing identity of the code signing certificate must be provided to the tool. Previously, this was hardcoded into the workflows. That was not ideal because the workflows are intended to be generally applicable to any project, including 3rd party projects which will have a different signing identity from that of Arduino's certificates. In addition to posing an inconvenience to hard forks, the previous hardcoding also made it more difficult for community contributors to validate changes to the release system in their fork in preparation for submitting a pull request to Arduino's repository. In addition to the configuration file that was previously used to configure the identity, Gon supports configuration via environment variables. Environment variables are already used for the other certificate-specific configuration. The reason an environment variable was not done for the identity is simply that Gon did not have support for doing so at the time the notarization system was developed. However, it is supported from version 0.0.28. Since this is public information, a repository variable (as opposed to the GitHub Actions secrets mechanism used by the workflow for the non-public data) is used to configure the identity via the repository settings. This will make it possible to run the workflow with any suitable certificate and credentials, without any changes to the workflow code. --- Even though it no longer contains any data, it was necessary to leave the empty `sign` block in the **Gon** configuration file, as the presence of this block is required by the tool: ``` ❗️ `sign` configuration required with `source` set When you set the `source` configuration, you must also specify the `sign` configuration to sign the input files. ```
1 parent c2a5278 commit b9721b5

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/workflows/publish-go-nightly-task.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,7 @@ jobs:
165165
source = ["${{ env.DIST_DIR }}/${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"]
166166
bundle_id = "cc.arduino.${{ env.PROJECT_NAME }}"
167167
168-
sign {
169-
application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)"
170-
}
168+
sign {}
171169
172170
# Ask Gon for zip output to force notarization process to take place.
173171
# The CI will ignore the zip output, using the signed binary only.
@@ -178,6 +176,7 @@ jobs:
178176
179177
- name: Sign and notarize binary
180178
env:
179+
AC_APPLICATION_IDENTITY: ${{ vars.AC_APPLICATION_IDENTITY }}
181180
AC_USERNAME: ${{ secrets.AC_USERNAME }}
182181
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
183182
AC_PROVIDER: ${{ vars.AC_PROVIDER }}

.github/workflows/release-go-task.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,7 @@ jobs:
165165
source = ["${{ env.DIST_DIR }}/${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"]
166166
bundle_id = "cc.arduino.${{ env.PROJECT_NAME }}"
167167
168-
sign {
169-
application_identity = "Developer ID Application: ARDUINO SA (7KT7ZWMCJT)"
170-
}
168+
sign {}
171169
172170
# Ask Gon for zip output to force notarization process to take place.
173171
# The CI will ignore the zip output, using the signed binary only.
@@ -178,6 +176,7 @@ jobs:
178176
179177
- name: Sign and notarize binary
180178
env:
179+
AC_APPLICATION_IDENTITY: ${{ vars.AC_APPLICATION_IDENTITY }}
181180
AC_USERNAME: ${{ secrets.AC_USERNAME }}
182181
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
183182
AC_PROVIDER: ${{ vars.AC_PROVIDER }}

0 commit comments

Comments
 (0)