ArgoCD Helm: Impossible to create a PDB for redis-ha in ArgoCD

[forward2you]

Describe the bug

Describe the bug
Currently in the ArgoCD redis/pdb helm template, there's logic that prevents the PDB to be created if redis-ha is enabled.
The safe behavior is to enable both redis-ha and pdb.

Related helm chart

argo-cd

Helm chart version

8.1.3

To Reproduce

redis-ha:
enabled: true
redis:
pdb:
enabled: true
minAvailable: 1

No PDB is created. As it's blocked here

Related old issue

Expected behavior

Both redis-ha and redis pdb are enabled

With this config, will create PDB

redis-ha:
  enabled: true
redis:
  pdb:
    enabled: true
    minAvailable: 1

Screenshots

No response

Additional context

No response

[yu-croco]

Currently in the ArgoCD redis/pdb helm template, there's logic that prevents the PDB to be created if redis-ha is enabled.
The safe behavior is to enable both redis-ha and pdb.

As you can see the code, we expect that users use redis or redis-ha, not use them at the same time.
There are many logics that we expect it.

[forward2you]

Hi @yu-croco , thank you for your respond.
My understanding is, we either I use redis with PDB, or use Redis ha without PDB, right?

The reason I request this issue is, I'm getting this warning from Google cloud Kubernetes cluster suggestions.

[yu-croco]

I wonder you can configure PDB under redis-ha's block, instead of argo-helm directly ? We don't have enough capability to follow all the features of upstream/subcharts, so we recommend you to refer them directly if you wan to deep dive.
https://github.com/DandyDeveloper/charts/blob/master/charts/redis-ha/values.yaml#L160

redis-ha:
  podDisruptionBudget:
    # ....  

[yu-croco]

Hi @forward2you , any update against above ?