-
Couldn't load subscription status.
- Fork 184
Open
Description
Hi. I have a problem with argocd-notifications-controller sending wrong labels from different notification to alertmanager.
Could it be because of this line?
| notification.Alertmanager.Labels = n.Labels |
From my understanding n is a shared object (original template) in
notifications-engine/pkg/api/api.go
Lines 29 to 31 in e3fe626
| type api struct { | |
| notificationServices map[string]services.NotificationService | |
| templatesService templates.Service |
notifications-engine/pkg/api/api.go
Line 93 in e3fe626
| templatesService, err := templates.NewService(cfg.Templates) |
notifications-engine/pkg/templates/service.go
Lines 25 to 26 in e3fe626
| for name, cfg := range templates { | |
| templater, err := cfg.GetTemplater(name, f) |
And because of this, shared n.Labels gets modified in
| n.Labels[k] = val |
Metadata
Metadata
Assignees
Labels
No labels