[Rinse and Repeat] Parameter passing

[pehunka]

Hi,

I think I found a bug in Basket class

Basket class contains List<String> of items. Function basket.placeOrder() pass this item's list to another list inside SingletonOrderRepository.class and than this list is cleared via items.clear(). This is problem because value is pass via reference copy and list inside SingletonOrderRepository is cleared also.

Arquillian's tests looks ok on first sight because they testing only size not what they are really holding inside.

You need eather
items = new ArrayList<String>() instead of items.clear() inside Basket.class

or

orders.add(new ArrayList<String>(order));
instead of orders.add(order); inside SingletonOrderRepository.class

[mojavelinux]

Absolutely correct. The items collection needs to be copied when it is passed to addOrder. The assertion should also go deeper so that this error would get caught.

Willing to send a pull request with the correct code sample?

[pehunka]

Hi Dan,

already did :-) Its pull request num.8 in arquillian-examples repo.. If you need send pull request here, just tell me..

[mojavelinux]

Oh, perfect! I'll link it to this issue.

arquillian/arquillian-examples#8

[mojavelinux]

The change also needs to be made in the guide itself. Did you create a pull request already for the guide?

[pehunka]

Not yet :-) I have not environment that is needed for page editing (Ruby), but maybe I will find some spare time on this weekend. Also I found some code that need polish in functional testing guide (its not working -> wrong ids of page elements). So I send it also.

Btw. if you are interested for some vaadin 7 + graphene + drone code example, I have one :-) It's combination of functional testing and persistence examples.. I was preparing presentation about arquillian for our department and I need to prep some examples :-)