-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Labels
Description
General maintenance
PeerDependenciesRemove lodash as a dependency by refactoring its usage to vanilla js. If this isn’t straight-forward then I’d like to limit it’s usage so that consumers of this lib are not weighed down by it - this would be obvious if we bundled the build output which we don’t, currently I think there’s an issue in that we are exposing the es6 import keyword here. Not an issue if you’re using this lib in a project with a bundler, but it may trip some users up. In any case if the deps can be removed entirely then I think this would be the best way forward.- Test the component x-browser and add any necessary fixes, I think that innerText might be an issue on IE. I’m not sure what it has been tested against but it wouldn’t do any harm to do some more testing
- Update the documentation to ensure it covers all the bases, for example when I starting looking at this lib it was difficult to understand how to use it with StyledComponents without digging through the code.
- Improve the props vs state anti-pattern going on in the component. Bug here
Features
- Introduce some XSS mitigation with using the component with props.sanitise
Run the linting & tests on pre-commit using Husky