Skip to content

Commit 5c94d71

Browse files
authored
Merge pull request #257 from astro-informatics/mmg/document-cubic-generate-precomputes
Indicate cubic memory overhead in `generate_precomputes` docstring
2 parents f08c6bc + bfc9a39 commit 5c94d71

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

s2fft/recursions/price_mcewen.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,11 @@ def generate_precomputes(
2121
L_lower: int = 0,
2222
) -> List[np.ndarray]:
2323
r"""
24-
Compute recursion coefficients with :math:`\mathcal{O}(L^2)` memory overhead.
25-
In practice one could compute these on-the-fly but the memory overhead is
26-
negligible and well worth the acceleration.
24+
Compute recursion coefficients with :math:`\mathcal{O}(L^3)` memory overhead.
25+
26+
The corresponding JAX implementation in :py:func:`generate_precomputes_jax` has a
27+
:math:`\mathcal{O}(L^2)` overhead and so should generally be preferred, particularly
28+
for large :math:`L`.
2729
2830
Args:
2931
L (int): Harmonic band-limit.

0 commit comments

Comments
 (0)