Apply suggestion from @StephenButtolph

Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Sam Liokumovich <65994425+samliok@users.noreply.github.com>

Author: samliok

database/leveldb/db.go

@@ -200,17 +200,15 @@ type config struct {
 
 // randomizeCompactionParams sets compaction parameters in cfg to random values
 // to spread out compaction behavior across different nodes.
+//
+// #nosec G404 // non-crypto randomness is fine here
 func randomizeCompactionParams(cfg *config) {
-	r := rand.New(rand.NewSource(time.Now().UnixNano())) // #nosec G404 -- non-crypto randomness is fine here
-
-	// generate random defaults for CompactionL0Trigger
-	compactionL0Trigger := r.Intn(maxCompactionL0Trigger-minCompactionL0Trigger+1) + minCompactionL0Trigger
-
-	// generate random defaults for CompactionTableSize
-	compactionTableSize := (r.Intn(maxCompactionTableSize-minCompactionTableSize+1) + minCompactionTableSize)
-
-	cfg.CompactionL0Trigger = compactionL0Trigger
-	cfg.CompactionTableSize = compactionTableSize
+	const (
+		rangeCompactionL0Trigger = maxCompactionL0Trigger - minCompactionL0Trigger + 1
+		rangeCompactionTableSize = maxCompactionTableSize - minCompactionTableSize + 1
+	)
+	cfg.CompactionL0Trigger = rand.Intn(rangeCompactionL0Trigger) + minCompactionL0Trigger
+	cfg.CompactionTableSize = rand.Intn(rangeCompactionTableSize) + minCompactionTableSize
 }
 
 // New returns a wrapped LevelDB object.