Skip to content

Commit 5257cac

Browse files
committed
incorporate martin feedback
1 parent 325c041 commit 5257cac

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

.devcontainer/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ ENV AVALANCHEGO_PLUGIN_PATH=$GOPATH/src/github.com/ava-labs/avalanchego/build/pl
88
# Download AvalancheGo Binary
99
WORKDIR /
1010
COPY ./scripts/versions.sh /
11-
COPY ./.devcontainer/install.sh /
11+
COPY ./.devcontainer/install_avalanchego.sh /
1212

1313
ENV AVALANCHEGO_EXEC_PATH=/avalanchego
1414

15-
RUN bash -c "source ./install.sh"
15+
RUN bash -c "source ./install_avalanchego.sh"
1616

1717
# Install Node.js and npm using the official Node.js image
1818
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && apt-get install -y nodejs

.devcontainer/install.sh renamed to .devcontainer/install_avalanchego.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/bin/bash
22
# Pulls latest pre-built node binary from GitHub
3-
# Context of container, NOT local workspace
43

54
#stop on errors
65
set -e
@@ -60,6 +59,7 @@ else
6059
exit
6160
fi
6261

62+
# Define architecture
6363
foundArch="$(uname -m)"
6464

6565
if [ "$foundArch" = "aarch64" ]; then
@@ -80,14 +80,8 @@ fi
8080

8181
# Import environment variables
8282
source ./versions.sh
83-
echo $AVALANCHEGO_VERSION
84-
echo $getArch
85-
echo "PRINTED AGO VERSION!"
8683

8784
# Download AvalancheGo binary
88-
echo "https://github.com/ava-labs/avalanchego/releases/download/$AVALANCHEGO_VERSION/avalanchego-linux-$getArch-$AVALANCHEGO_VERSION.tar.gz"
8985
curl -LJ -o avalanchego.tar.gz "https://github.com/ava-labs/avalanchego/releases/download/$AVALANCHEGO_VERSION/avalanchego-linux-$getArch-$AVALANCHEGO_VERSION.tar.gz"
90-
echo "DOWNLOADED TAR FILE"
9186
tar -xzf avalanchego.tar.gz --wildcards '*/avalanchego' --strip-components=1 -C /avalanchego
92-
echo "TARRED THE FILE!"
9387
rm avalanchego.tar.gz

0 commit comments

Comments
 (0)