#241 - Ambiguous constructor error when defining an injected and non-injected c'tor

Author: rbygrave

inject-test/src/test/java/org/example/coffee/core/WithMultiCtor.java

@@ -0,0 +1,19 @@
+package org.example.coffee.core;
+
+import io.avaje.inject.Component;
+import jakarta.inject.Inject;
+
+@Component
+public class WithMultiCtor {
+
+  final Steamer steamer;
+
+  public WithMultiCtor(Integer ignored) {
+    this.steamer = null;
+  }
+
+  @Inject
+  public WithMultiCtor(Steamer steamer) {
+    this.steamer = steamer;
+  }
+}

inject-test/src/test/java/org/example/coffee/core/WithMultiCtorTest.java

@@ -0,0 +1,18 @@
+package org.example.coffee.core;
+
+import io.avaje.inject.BeanScope;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class WithMultiCtorTest {
+
+  @Test
+  void injectConstructor_expect_notAmbiguous() {
+    try (BeanScope beanScope = BeanScope.builder().build()) {
+      WithMultiCtor withMultiCtor = beanScope.get(WithMultiCtor.class);
+
+      assertThat(withMultiCtor.steamer).isNotNull();
+    }
+  }
+}

inject/src/main/java/io/avaje/inject/spi/Builder.java

@@ -98,6 +98,36 @@ static Builder newBuilder(List<SuppliedBean> suppliedBeans, List<EnrichBean> enr
    */
   void addInjector(Consumer<Builder> injector);
 
+  /**
+   * Get a dependency.
+   */
+  <T> T get(Class<T> cls);
+
+  /**
+   * Get a named dependency.
+   */
+  <T> T get(Class<T> cls, String name);
+
+  /**
+   * Get a dependency.
+   */
+  <T> T get(Type cls);
+
+  /**
+   * Get a named dependency.
+   */
+  <T> T get(Type cls, String name);
+
+  /**
+   * Get an optional dependency.
+   */
+  <T> Optional<T> getOptional(Class<T> cls);
+
+  /**
+   * Get an optional named dependency.
+   */
+  <T> Optional<T> getOptional(Class<T> cls, String name);
+
   /**
    * Get an optional dependency.
    */
@@ -108,6 +138,16 @@ static Builder newBuilder(List<SuppliedBean> suppliedBeans, List<EnrichBean> enr
    */
   <T> Optional<T> getOptional(Type cls, String name);
 
+  /**
+   * Get an optional dependency potentially returning null.
+   */
+  <T> T getNullable(Class<T> cls);
+
+  /**
+   * Get an optional named dependency potentially returning null.
+   */
+  <T> T getNullable(Class<T> cls, String name);
+
   /**
    * Get an optional dependency potentially returning null.
    */
@@ -118,6 +158,16 @@ static Builder newBuilder(List<SuppliedBean> suppliedBeans, List<EnrichBean> enr
    */
   <T> T getNullable(Type cls, String name);
 
+  /**
+   * Return Provider of T given the type.
+   */
+  <T> Provider<T> getProvider(Class<T> cls);
+
+  /**
+   * Return Provider of T given the type and name.
+   */
+  <T> Provider<T> getProvider(Class<T> cls, String name);
+
   /**
    * Return Provider of T given the type.
    */
@@ -137,29 +187,34 @@ static Builder newBuilder(List<SuppliedBean> suppliedBeans, List<EnrichBean> enr
   <T> Provider<T> getProviderFor(Class<?> cls, Type type);
 
   /**
-   * Get a dependency.
+   * Get a list of dependencies for the type.
    */
-  <T> T get(Type cls);
+  <T> List<T> list(Class<T> type);
 
   /**
-   * Get a named dependency.
+   * Get a list of dependencies for the type.
    */
-  <T> T get(Type cls, String name);
+  <T> List<T> list(Type type);
 
   /**
-   * Get a list of dependencies for the type.
+   * Get a set of dependencies for the type.
    */
-  <T> List<T> list(Type interfaceType);
+  <T> Set<T> set(Class<T> type);
 
   /**
    * Get a set of dependencies for the type.
    */
-  <T> Set<T> set(Type interfaceType);
+  <T> Set<T> set(Type type);
+
+  /**
+   * Return a map of dependencies keyed by qualifier name.
+   */
+  <T> Map<String, T> map(Class<T> type);
 
   /**
    * Return a map of dependencies keyed by qualifier name.
    */
-  <T> Map<String, T> map(Type interfaceType);
+  <T> Map<String, T> map(Type type);
 
   /**
    * Build and return the bean scope.