feat: srw #1586
Open
feat: srw #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-bq
force-pushed
the
feat-srw
branch
2 times, most recently
from
b3b7ada to
367647b
Compare
sergiyvamz
reviewed
Nov 4, 2025
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
docs/using-the-jdbc-driver/using-plugins/UsingTheSimpleReadWriteSplittingPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
...les/AWSDriverExample/src/main/java/software/amazon/SimpleReadWriteSplittingMySQLExample.java
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
wrapper/src/main/java/software/amazon/jdbc/plugin/AuroraInitialConnectionStrategyPlugin.java
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
| this.pluginService = pluginService; | ||
| this.properties = properties; | ||
| this.writeEndpoint = writeEndpoint; | ||
| this.readEndpoint = SRW_READ_ENDPOINT.getString(properties); |
Contributor
There was a problem hiding this comment.
Does it mean that SRW_READ_ENDPOINT is optional parameter?
Contributor
Author
There was a problem hiding this comment.
I've updated it so that SRW_READ_ENDPOINT is required
sergiyvamz
reviewed
Nov 4, 2025
| } | ||
|
|
||
| private boolean isWriteEndpoint(final @NonNull HostSpec hostSpec) { | ||
| return Objects.equals(hostSpec.getHost(), this.writeEndpoint); |
Contributor
There was a problem hiding this comment.
We need to use getHostAndPort() and verify equalsIgnoreCase()
Contributor
Author
There was a problem hiding this comment.
Are we expecting that the port is included in the endpoint?
sergiyvamz
reviewed
Nov 4, 2025
wrapper/src/main/java/software/amazon/jdbc/plugin/srw/SimpleReadWriteSplittingPlugin.java
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
wrapper/src/main/java/software/amazon/jdbc/plugin/srw/SimpleReadWriteSplittingPlugin.java
Show resolved
Hide resolved
sergiyvamz
reviewed
Nov 4, 2025
wrapper/src/test/java/integration/container/tests/SimpleReadWriteSplittingTest.java
Outdated
Show resolved
Hide resolved
sophia-bq
force-pushed
the
feat-srw
branch
4 times, most recently
from
63f3490 to
3f4280b
Compare
karenc-bq
reviewed
Nov 10, 2025
wrapper/src/main/java/software/amazon/jdbc/plugin/failover/FailoverConnectionPlugin.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
introduces the Simple Read/Write Splitting Plugin (srw)
Description
an alternative to the existing Read/Write Splitting Plugin that connects directly to specified read and write endpoints
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.