-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Closed
Labels
bugThis issue is a bug.This issue is a bug.closing-soonThis issue will automatically close in 4 days unless further comments are made.This issue will automatically close in 4 days unless further comments are made.dependenciesThis issue is a problem in a dependency.This issue is a problem in a dependency.p3This is a minor priority issueThis is a minor priority issueresponse-requestedWaiting on additional info and feedback. Will move to "closing-soon" in 7 days.Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.source-distributioncli v2 source distritbution related issuescli v2 source distritbution related issues
Description
Describe the bug
Note from https://pypi.org/project/pep517/
Deprecated high-level
For now, pep517 also contains higher-level functions which install the build dependencies into a temporary environment and build a wheel/sdist using them. This is a rough implementation, e.g. it does not do proper build isolation. The PyPA build project is recommended as an alternative, although it’s still quite young in October 2020. This layer of functionality in pep517 is now deprecated, but won’t be removed for some time, as there is code relying on it.
Regression Issue
- Select this option if this issue appears to be a regression.
Expected Behavior
build should be used instead pep517.
Current Behavior
grep output
[tkloczko@pers-tkloczko aws-cli-2.27.2]$ grep -r pep517
grep: backends/__pycache__/pep517.cpython-310.pyc: binary file matches
pyproject.toml:build-backend = "pep517"
pyproject.toml: # pep517 backend. When we explicitly address this change, we should be able to remove these filters.
requirements-dev-lock.txt:pep517==0.13.1 \
requirements-dev-lock.txt: # pep517
tests/backends/build_system/integration/test_build_system.py: "Cannot import 'pep517'",
tests/backends/test_pep517.py:import backends.pep517
tests/backends/test_pep517.py: sdist_name = backends.pep517.build_sdist(str(tmpdir), config_settings)
tests/backends/test_pep517.py: assert unpacked_sdist.join("backends", "pep517.py").check()
tests/backends/test_pep517.py: wheel_name = backends.pep517.build_wheel(str(tmpdir), config_settings)
tests/backends/test_pep517.py: assert not unpacked_wheel_dir.join("backends", "pep517.py").check()
tests/backends/test_pep517.py: wheel_name = backends.pep517.build_editable(str(tmpdir), config_settings)
tests/backends/test_pep517.py: # backends.pep517.build_editable.
tests/backends/test_pep517.py: dist_info_dirname = backends.pep517.prepare_metadata_for_build_wheel(
tests/backends/test_pep517.py: dist_info_dirname = backends.pep517.prepare_metadata_for_build_editable(
tests/backends/test_pep517.py: requirements = backends.pep517.get_requires_for_build_sdist(
tests/backends/test_pep517.py: requirements = backends.pep517.get_requires_for_build_wheel(
tests/backends/test_pep517.py: extras = set(backends.pep517.read_sdist_extras())
tests/backends/test_pep517.py:# snippet should alert us if we break anything in the pep517 module.Reproduction Steps
Just grep across source tree.
Possible Solution
No response
Additional Information/Context
N/A
CLI version used
2.27.2
Environment details (OS name and version, etc.)
Linux x86/64
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugThis issue is a bug.This issue is a bug.closing-soonThis issue will automatically close in 4 days unless further comments are made.This issue will automatically close in 4 days unless further comments are made.dependenciesThis issue is a problem in a dependency.This issue is a problem in a dependency.p3This is a minor priority issueThis is a minor priority issueresponse-requestedWaiting on additional info and feedback. Will move to "closing-soon" in 7 days.Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.source-distributioncli v2 source distritbution related issuescli v2 source distritbution related issues