Skip to content

Reduce Duplication between ACMachineTest and MachineTest #83

@baldawar

Description

@baldawar

Tracking ticket to follow up on #82 (comment)

What I have been doing recently is added rulesForJSONEvent tests to ACMachineTest and adding rulesForEvent tests (otherwise identical) to MachineTest. I think that is the intended difference between the two test classes? So change this and add a version to ACMachineTest? Of course, we should probably think through a path forward to stop duplicating all tests.

Need to

  • combine tests cases (some are missing from ACMachineTest and others are lacking in MachineTest)
  • build a wrapper method to call both rulesForJSONEvent and rulesForEvent
  • handle cases when both should be returning different results for Array Consistency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomershelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions