-
Notifications
You must be signed in to change notification settings - Fork 81
Simplify defaultConnection fetch and backward-compat env vars #1626
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Parent PRD
What to build
Update fetchDefaultConnection to use ${apiBase}defaultConnection as the single fetch URL, removing the SageMaker fallback URL guessing. Update the DefaultConnectionData schema to accept both old field names (GRAPH_EXP_PUBLIC_OR_PROXY_ENDPOINT, GRAPH_EXP_USING_PROXY_SERVER) and the canonical GRAPH_EXP_CONNECTION_URL. Update mapToConnection to handle both formats. Update process-environment.sh to support old Docker env var names (PUBLIC_OR_PROXY_ENDPOINT, USING_PROXY_SERVER) with deprecation warnings, mapping them to the new canonical names.
Type: HITL — requires review before completion.
Acceptance criteria
-
fetchDefaultConnectionfetches from${apiBase}defaultConnectiononly (no SageMaker fallback) -
DefaultConnectionDataschema accepts old field names alongside new ones -
mapToConnectionproduces correctConnectionConfigfrom both old and newdefaultConnection.jsonformats -
process-environment.shmaps old env var names to new canonical names -
process-environment.shlogs deprecation warnings when old env var names are used -
GRAPH_EXP_CONNECTION_URLis the canonical field name for the database URL - Tests verify schema parsing for both old and new field names
- Tests verify
mapToConnectionoutput for both formats
Blocked by
- Blocked by Create apiBase module and wire client fetch to /api/* #1621
- Blocked by Simplify ConnectionConfig — remove url and proxyConnection #1622
User stories addressed
- User story 3
- User story 4
- User story 5
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request