Reveal the issue

Author: sfodagain

source/channel.c

@@ -1005,7 +1005,8 @@ int aws_channel_slot_on_handler_shutdown_complete(
 }
 
 size_t aws_channel_slot_downstream_read_window(struct aws_channel_slot *slot) {
-    AWS_ASSERT(slot->adj_right);
+    AWS_LOGF_ERROR(AWS_LS_IO_CHANNEL, "=== Reading from slot %p (%p)", (void*)slot, (void*)slot->adj_right);
+    AWS_FATAL_ASSERT(slot->adj_right);
     return slot->channel->read_back_pressure_enabled ? slot->adj_right->window_size : SIZE_MAX;
 }
 

source/channel_bootstrap.c

@@ -1563,11 +1563,13 @@ static void s_on_server_channel_on_setup_completed(struct aws_channel *channel,
     AWS_LOGF_TRACE(
         AWS_LS_IO_CHANNEL_BOOTSTRAP,
         "id=%p: Setting up socket handler on channel "
-        "%p with handler %p on slot %p.",
+        "%p with handler %p on slot %p (%p, %p)",
         (void *)channel_data->server_connection_args->bootstrap,
         (void *)channel,
         (void *)socket_channel_handler,
-        (void *)socket_slot);
+        (void *)socket_slot,
+        (void *)socket_slot->adj_right,
+        (void *)socket_slot->adj_left);
 
     if (aws_channel_slot_set_handler(socket_slot, socket_channel_handler)) {
         err_code = aws_last_error();
@@ -1583,6 +1585,9 @@ static void s_on_server_channel_on_setup_completed(struct aws_channel *channel,
              * when a TLS connection has been successfully established. At that point, we signal a successful TLS
              * handshake, which also makes the server name and protocol available (if provided).
              */
+            // FIXME A code path used in the tls_server_hangup_during_negotiation test needs slots from that are set up
+            //   by s_setup_server_tls.
+            // FIXME AWS_ASSERT compiles to noop in our CI.
             s_tls_server_on_negotiation_result(socket_channel_handler, socket_slot, err_code, channel_data);
             return;
         }