How about failing a test that are not skipped?

sfodagain · sfodagain · commit 1c1bd9259ed5 · 2025-10-31T19:04:27.000-07:00
diff --git a/tests/Mqtt5ClientTest.cpp b/tests/Mqtt5ClientTest.cpp
@@ -1876,7 +1876,6 @@ static int s_TestMqtt5SubUnsub(Aws::Crt::Allocator *allocator, void *)
 
     ASSERT_TRUE(receivedCount == 1);
 
-    return AWS_OP_ERR;
     return AWS_OP_SUCCESS;
 }
 AWS_TEST_CASE(Mqtt5SubUnsub, s_TestMqtt5SubUnsub)
diff --git a/tests/MqttClientCredentialsTest.cpp b/tests/MqttClientCredentialsTest.cpp
@@ -974,6 +974,7 @@ static int s_TestIoTMqtt311ConnectWSStatic(Aws::Crt::Allocator *allocator, void
     aws_string_destroy(accessKeyId);
     aws_string_destroy(secretAccessKey);
     aws_string_destroy(sessionToken);
+    return AWS_OP_ERR;
     return AWS_OP_SUCCESS;
 }
 AWS_TEST_CASE(IoTMqtt311ConnectWSStatic, s_TestIoTMqtt311ConnectWSStatic)

Original file line number	Diff line number	Diff line change
`@@ -1876,7 +1876,6 @@ static int s_TestMqtt5SubUnsub(Aws::Crt::Allocator allocator, void )`
`1876`	`1876`
`1877`	`1877`	`ASSERT_TRUE(receivedCount == 1);`
`1878`	`1878`
`1879`		`- return AWS_OP_ERR;`
`1880`	`1879`	`return AWS_OP_SUCCESS;`
`1881`	`1880`	`}`
`1882`	`1881`	`AWS_TEST_CASE(Mqtt5SubUnsub, s_TestMqtt5SubUnsub)`
Original file line number	Diff line number	Diff line change
`@@ -974,6 +974,7 @@ static int s_TestIoTMqtt311ConnectWSStatic(Aws::Crt::Allocator *allocator, void`
`974`	`974`	`aws_string_destroy(accessKeyId);`
`975`	`975`	`aws_string_destroy(secretAccessKey);`
`976`	`976`	`aws_string_destroy(sessionToken);`
	`977`	`+ return AWS_OP_ERR;`
`977`	`978`	`return AWS_OP_SUCCESS;`
`978`	`979`	`}`
`979`	`980`	`AWS_TEST_CASE(IoTMqtt311ConnectWSStatic, s_TestIoTMqtt311ConnectWSStatic)`