Skip to content

Version on PyPi does not match any commit #25

@sndrtj

Description

@sndrtj

The most recent version of fuzzyset on pypi does not match any commit.

As of March 5 of this year, version 0.19.0 is the most recent version on PyPi. This seems to be one patch version ahead of the most recent commit on master, which bumped the version to 0.0.18.

Running a diff shows the PyPI version contains a difference on the _distance function of both cFuzzySet and fuzzySet (as well as a large difference in the .C file, but that may simply be a result of re-running cython).

Version 0.19.0 seems to introduce a performance regression due to recomputing the levenshtein distance twice in the fuzzySet implementation. Specifically, _distance function now reads:

 def _distance(str1, str2):
     distance = Levenshtein.distance(str1, str2)
     result = Levenshtein.distance(str1, str2)
     if len(str1) > len(str2):
         return 1 - float(distance) / len(str1)
     else:
         return 1 - float(distance) / len(str2)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions