From 8551612545c971b321c7f12609e49206a7c49fb8 Mon Sep 17 00:00:00 2001 From: Markus Reich Date: Sun, 8 Nov 2015 10:42:55 +0100 Subject: [PATCH 1/2] Remove check on null value In logout method the user is set to null, this wouldn't work proberly, if there's a check on not null! --- baasbox.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/baasbox.js b/baasbox.js index fefa7d3..8d036d5 100644 --- a/baasbox.js +++ b/baasbox.js @@ -39,9 +39,6 @@ var BaasBox = (function() { } function setCurrentUser(userObject) { - if (userObject === null) { - return; - } this.user = userObject; // if the user is using Zepto, then local storage must be used (if supported by the current browser) if (window.Zepto && window.localStorage) { @@ -672,4 +669,4 @@ var BaasBox = (function() { return !$.cookie(key); }; -})); \ No newline at end of file +})); From ff1d5e9d90ac0a59cde788685725c877f0251f14 Mon Sep 17 00:00:00 2001 From: Markus Reich Date: Sun, 8 Nov 2015 10:44:18 +0100 Subject: [PATCH 2/2] Fail routine for logout There could also be errors on logout --- baasbox.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/baasbox.js b/baasbox.js index 8d036d5..d59e718 100644 --- a/baasbox.js +++ b/baasbox.js @@ -174,6 +174,9 @@ var BaasBox = (function() { .fail(function (error) { deferred.reject(error) }) + }) + .fail(function(error) { + deferred.reject(error); }); return deferred.promise(); },