`pgformatter` Docker image is broken

[andrew-farries]

The most recent version of pgformatter pushed to Dockerhub appears to be broken:

To reproduce:

$ docker rmi backplane/pgformatter:latest
$ docker run --rm backplane/pgformatter:latest

Produces the output:

Uncaught exception: Uncaught exception: Uncaught exception: Uncaught exception: Possible precedence problem between ! and string eq at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/Beautify.pm line 510.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Possible precedence problem between ! and string eq at /usr/l"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/Beautify.pm line 510
        require pgFormatter/Beautify.pm called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        pgFormatter::CLI::BEGIN() called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        eval {...} called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
Compilation failed in require at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Possible precedence problem between ! and"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        pgFormatter::CLI::BEGIN() called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        eval {...} called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Uncaught exception: Possible precedence p"...) called at /usr/local/lib/perl5/site_perl/5.42.0/pgFormatter/CLI.pm line 26
        require pgFormatter/CLI.pm called at /usr/local/bin/pg_format line 45
Compilation failed in require at /usr/local/bin/pg_format line 45.
 at /usr/local/bin/pg_format line 19.
        main::__ANON__("Uncaught exception: Uncaught exception: Uncaught exception: P"...) called at /usr/local/bin/pg_format line 45

As there is only a latest tag available there is no way to pin to the previous working version.

[actualben]

Thanks for the report. I can reproduce this.

• This seems to be related to: https://perldoc.perl.org/5.41.4/perldelta#New-Warnings
• I see that there have been some big changes upstream since the last release (v5.6) so that slightly complicates things.
• Here's a simplified test case:

ARG PERL_VERSION=5
FROM perl:${PERL_VERSION}-slim
ARG PGFORMATTER_VERSION=v5.6

ENV CHARSET=UTF-8

WORKDIR /work
RUN curl -fsSL -o /src.tgz "https://api.github.com/repos/darold/pgFormatter/tarball/${PGFORMATTER_VERSION}"
RUN tar -xvzf /src.tgz --strip-components 1
RUN perl Makefile.PL
RUN make
RUN make install

# test run (should fail the build if the program won't run)
WORKDIR /
RUN /usr/local/bin/pg_format

ENTRYPOINT ["/usr/local/bin/pg_format"]

This fails to run:
docker build --build-arg PERL_VERSION=5.41 .

This runs:
docker build --build-arg PERL_VERSION=5.40 .

So that seems to confirm the theory. For now I'll pin my container to perl:5.40-slim and open an issue upstream, but they probably already know about it.

Update: It looks like HEAD upstream also has the problem:

This runs:
docker build --build-arg PERL_VERSION=5.40 --build-arg PGFORMATTER_VERSION=master .

These fail to run:
docker build --build-arg PERL_VERSION=5.41 --build-arg PGFORMATTER_VERSION=master .

docker build --build-arg PERL_VERSION=5.42 --build-arg PGFORMATTER_VERSION=master .

[actualben]

Opened darold/pgFormatter#363

[actualben]

The newly 5.40-pinned image is released to docker hub.

✅ docker run --rm --pull=always backplane/pgformatter -h

[actualben]

PR sent to (and merged!) upstream. I'll hold this open until the next pgformatter release, then I can unpin from 5.40.