Skip to content

Feedback after first test #30

@zonofthor

Description

@zonofthor

Just a raw feedback after 2 hours spent on testing component. Promising but fixes needed (imho).

  1. Options cannot be passed as readable meaning they are prone to mutation. A no no since we want functional coding style.
  2. No way to render icon in label (only allows string type).
  3. onOptionChange is documented as
onOptionChange(data: any) => void - executed after an option is selected or removed

is that really correct "or option removed" - the options list should not be mutable?
4. I found this lib when trying to find a minimalistic library with first class support for styled-components. A little disappointed, having to edit themeProvider as object and even then it is quite difficult to get to some styling properties, e.g. I want to reduce focused border width.
5. Cannot find a way to support cursor: pointer over control.
6. I see no possibility to hide "select options" text inside empy select
[edit: set placeholder=""] - hackish though

Just my quick tidbits. Good work, keep it up!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions