feat(truss): Pass environment name to create model from truss #2006
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talyaacovi
force-pushed
the
tal/pass-environment-name-to-create-model-from-truss
branch
from
c3f5eaa to
25ff984
Compare
talyaacovi
requested review from
jrochette,
ndeepak-baseten,
squidarth and
tyranitar
jrochette
approved these changes
Oct 24, 2025
talyaacovi
force-pushed
the
tal/pass-environment-name-to-create-model-from-truss
branch
from
1f24c34 to
6b8f893
Compare
ndeepak-baseten
approved these changes
Oct 27, 2025
talyaacovi
force-pushed
the
tal/pass-environment-name-to-create-model-from-truss
branch
from
6b8f893 to
50e42ae
Compare
talyaacovi
force-pushed
the
tal/pass-environment-name-to-create-model-from-truss
branch
from
50e42ae to
536d534
Compare
talyaacovi
deleted the
tal/pass-environment-name-to-create-model-from-truss
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
Pass environment_name to create_model_from_truss mutation instead of erroring. This PR needs to be merged first, which will replicate the error unless a feature flag is enabled.
Also will return an error if both
environmentandpromoteflags are used, as currently that behavior is buggy and we want to move away from eager promotion.💻 How
Remove error messaging if a new model is being pushed with a non-production environment name.
🔬 Testing
Locally, confirmed same error message if feature flag is disabled and that push succeeds if the flag is on. Will test in dev as well.