Merge pull request #446 from DannyBen/fix/strict-mode

Fix some incompatibilities with strict mode

Author: DannyBen

examples/config/src/lib/config.sh

@@ -8,7 +8,6 @@
 ## - Use any of the following functions to access and manipulate the values.
 ## - INI sections are optional (i.e., sectionless key=value pairs are allowed).
 ##
-
 ## Show all the key=value pairs from your config file
 config_show() {
   config_load
@@ -28,8 +27,8 @@ config_show() {
 ##   theme="$(config_get interface.theme)"
 ##
 config_get() {
-  local key="$1"
-  local default_value="$2"
+  local key="${1-}"
+  local default_value="${2-}"
 
   config_load
   echo "${ini["$key"]:-$default_value}"
@@ -40,7 +39,7 @@ config_get() {
 ##   config_set cloud.provider aws
 ##
 config_set() {
-  local key="$1"
+  local key="${1-}"
   shift
   local value="$*"
 
@@ -54,7 +53,7 @@ config_set() {
 ##   config_del login.email
 ##
 config_del() {
-  local key="$1"
+  local key="${1-}"
 
   config_load
   unset "ini[$key]"
@@ -93,7 +92,7 @@ config_reload() {
 ## Load an INI file (unless loaded) and populate the associative array
 ## NOTE: Normally there is no need to call this function, it is called as needed
 config_load() {
-  [[ "$config_loaded" == "true" ]] && return
+  [[ "${config_loaded-}" == "true" ]] && return
 
   declare -g CONFIG_FILE=${CONFIG_FILE:=config.ini}
   declare -g config_loaded=true

examples/config/src/lib/ini.sh

@@ -25,7 +25,6 @@
 ##   unset ini[section1.key1]
 ##   ini_save path/to/config.ini
 ##
-
 ## Load an INI file and populate the associative array `ini`.
 ini_load() {
   declare -gA ini

examples/help-command/src/help_command.sh

@@ -10,7 +10,7 @@
 ##       - name: command
 ##         help: Help subject
 ##
-command="${args[command]}"
+command="${args[command]:-}"
 long_usage=yes
 
 if [[ -z "$command" ]]; then

examples/ini/src/get_command.sh

@@ -1,8 +1,8 @@
 # Using the standard library (lib/ini.sh) to show a value from the config
 ini_load config.ini
 
-key="${args[key]}"
-value=${ini[$key]}
+key="${args[key]:-}"
+value=${ini[$key]:-}
 
 if [[ "$value" ]]; then
   echo "$key = $value"

examples/ini/src/lib/ini.sh

@@ -25,7 +25,6 @@
 ##   unset ini[section1.key1]
 ##   ini_save path/to/config.ini
 ##
-
 ## Load an INI file and populate the associative array `ini`.
 ini_load() {
   declare -gA ini

examples/render-mandoc/docs/download.1

@@ -14,7 +14,7 @@
 . ftr VB CB
 . ftr VBI CBI
 .\}
-.TH "download" "1" "October 2023" "Version 0.1.0" "Sample application"
+.TH "download" "1" "November 2023" "Version 0.1.0" "Sample application"
 .hy
 .SH NAME
 .PP

examples/render-mandoc/docs/download.md

@@ -1,6 +1,6 @@
 % download(1) Version 0.1.0 | Sample application
 % Lana Lang
-% October 2023
+% November 2023
 
 NAME
 ==================================================

lib/bashly/libraries/config/config.sh

@@ -27,8 +27,8 @@ config_show() {
 ##   theme="$(config_get interface.theme)"
 ##
 config_get() {
-  local key="$1"
-  local default_value="$2"
+  local key="${1-}"
+  local default_value="${2-}"
 
   config_load
   echo "${ini["$key"]:-$default_value}"
@@ -39,7 +39,7 @@ config_get() {
 ##   config_set cloud.provider aws
 ##
 config_set() {
-  local key="$1"
+  local key="${1-}"
   shift
   local value="$*"
 
@@ -53,7 +53,7 @@ config_set() {
 ##   config_del login.email
 ##
 config_del() {
-  local key="$1"
+  local key="${1-}"
 
   config_load
   unset "ini[$key]"
@@ -92,7 +92,7 @@ config_reload() {
 ## Load an INI file (unless loaded) and populate the associative array
 ## NOTE: Normally there is no need to call this function, it is called as needed
 config_load() {
-  [[ "$config_loaded" == "true" ]] && return
+  [[ "${config_loaded-}" == "true" ]] && return
 
   declare -g CONFIG_FILE=${CONFIG_FILE:=config.ini}
   declare -g config_loaded=true

lib/bashly/libraries/help/help_command.sh

@@ -10,7 +10,7 @@
 ##       - name: command
 ##         help: Help subject
 ##
-command="${args[command]}"
+command="${args[command]:-}"
 long_usage=yes
 
 if [[ -z "$command" ]]; then

lib/bashly/views/command/whitelist_filter.gtx

@@ -12,7 +12,7 @@ if whitelisted_args.any? or whitelisted_flags.any?
       > done
 
     else
-      > if [[ -n ${args['{{ arg.name }}']} ]] && [[ ! ${args['{{ arg.name }}']} =~ ^({{ arg.allowed.join '|' }})$ ]]; then
+      > if [[ -n ${args['{{ arg.name }}']:-} ]] && [[ ! ${args['{{ arg.name }}']:-} =~ ^({{ arg.allowed.join '|' }})$ ]]; then
       >   printf "%s\n" "{{ strings[:disallowed_argument] % { name: arg.name, allowed: arg.allowed.join(', ') } }}" >&2
       >   exit 1
       > fi
@@ -31,7 +31,7 @@ if whitelisted_args.any? or whitelisted_flags.any?
       > done
 
     else
-      > if [[ ${args['{{ flag.name }}']} ]] && [[ ! ${args['{{ flag.name }}']} =~ ^({{ flag.allowed.join '|' }})$ ]]; then
+      > if [[ ${args['{{ flag.name }}']:-} ]] && [[ ! ${args['{{ flag.name }}']:-} =~ ^({{ flag.allowed.join '|' }})$ ]]; then
       >   printf "%s\n" "{{ strings[:disallowed_flag] % { name: flag.name, allowed: flag.allowed.join(', ') } }}" >&2
       >   exit 1
       > fi