Switch from Optimization to OptimizationBase #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 62.39% 61.94% -0.45%
==========================================
Files 110 110
Lines 4952 4770 -182
==========================================
- Hits 3090 2955 -135
+ Misses 1862 1815 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oschulz
force-pushed
the
optimization-base
branch
2 times, most recently
from
738879d to
fc50e33
Compare
oschulz
force-pushed
the
optimization-base
branch
2 times, most recently
from
c41cfc3 to
93075b7
Compare
Using `transform_samples` in `mcmc_update_z_position!!` causes massive slowdown due to overhead. Use new `_transform_dsv!!` instead.
Optimization v5.0 removes algorithms and is mostly an empty wrapper for OptimizationBase, so use OptimizationBase directly.
oschulz
force-pushed
the
optimization-base
branch
from
93075b7 to
037a68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization v5.0 removes algorithms and is mostly an empty wrapper for OptimizationBase, so use OptimizationBase directly.