diff --git a/java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/TestCaseXmlRenderer.java b/java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/TestCaseXmlRenderer.java index 01a6dc91..28359880 100644 --- a/java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/TestCaseXmlRenderer.java +++ b/java/src/com/github/bazel_contrib/contrib_rules_jvm/junit5/TestCaseXmlRenderer.java @@ -33,18 +33,7 @@ public void toXml(XMLStreamWriter xml, TestData test) throws XMLStreamException decimalFormat.setRoundingMode(RoundingMode.HALF_UP); TestIdentifier id = test.getId(); - - String name; - if (test.isDynamic()) { - name = id.getDisplayName(); // [ordinal] name=value... - } else { - // Massage the name - name = id.getLegacyReportingName(); - int index = name.indexOf('('); - if (index != -1) { - name = name.substring(0, index); - } - } + String name = id.getLegacyReportingName(); xml.writeStartElement("testcase"); xml.writeAttribute("name", escapeIllegalCharacters(name)); diff --git a/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListenerTest.java b/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListenerTest.java index 24001d8b..915d58cb 100644 --- a/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListenerTest.java +++ b/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/BazelJUnitOutputListenerTest.java @@ -348,7 +348,7 @@ public void ensureTestCaseNamesAreProperlyEscaped() { Node item = xml.getElementsByTagName("testcase").item(0); String testName = item.getAttributes().getNamedItem("name").getNodeValue(); - assertEquals("[engine:mocked]/[class:ExampleTest]/[method:Weirdname", testName); + assertEquals("[engine:mocked]/[class:ExampleTest]/[method:Weirdname()]", testName); } @Test