Skip to content

Corrections made for using PMUC as a shared library in another project #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msv68 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Corrections made for using PMUC as a shared library in another project #36

msv68 wants to merge 7 commits into from

Conversation

@msv68
Copy link

@msv68 msv68 commented Mar 26, 2020 •
edited
Loading

There are several commits in this branch to merge into master.

  1. Add possibility to build RVM reader as a separate shared library. Added cmake-lib/CMakeLists.txt to build shared library on Windows and Linux. Removed some warnings.
  2. Fix incorrect treatment of the term ':=' in .att file. The patch fixes exception when a key is empty, like "Module:=".
  3. Add possibility to read RVM and ATT from streams. It allows for example opening a ZIP archive in memory and performing reading of decoded streams. By the way memory leak through m_attributeStream has been fixed.
  4. Support progress indication and user break in RVM reader.
  5. Fix for scaling of groups: consider m_scale parameter in translation vector.
  6. Fix the bug of skipping attributes for some groups when order in ATT file differs from order in RVM file.

@msv68 msv68 force-pushed the develop branch 3 times, most recently from 32159e2 to 004537b Compare March 26, 2020 16:32
nbogdan and others added 5 commits March 26, 2020 20:11
Add possibility to build RVM reader as a separate shared library
aa68c68 
Added cmake-lib/CMakeLists.txt to build shared library on Windows and Linux.
Make possibility to exclude the class rvmmeshhelper from the library to get rid of dependence on OpenGl.
For that the cmake Boolean option USE_MESH_HELPER has been added.
Removed some warnings.
Fix incorrect treatment of the term ':=' in .att file
c770ab4 
The patch fixes exception when a key is empty, like "Module:=".
Add possibility to read RVM and ATT from streams
56f12f1 
By the way fix memory leak through m_attributeStream.
Support progress indication and user break in RVM reader
260974c
Fix for scaling of groups: consider m_scale parameter in translation …
f9aad66 
…vector
Fix the bug of skipping attributes for some groups
80834cc 
When objects in ATT file follow in another order in comparison with RVM file
some objects could miss the attributes. The patch fixes this bug.
@nbogdanlogic nbogdanlogic force-pushed the develop branch 6 times, most recently from bdba4ab to 3c5925e Compare May 6, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@msv68