Directory as source, manifest format, and file output #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to specify a directory as a source (with additional options to control file pattern matching and recursiveness). Also added the ability to output the data to a file. New prefetch format added based on a manifest I was trying to create. My use case for these changes was that I have several thousand files that I want to create a manifest file for dynamic downloads.
Directory as source, manifest format, and file output
|
@dexdexdex @kvnchen @karlhe @kevindashgit @valbellix Do you think one of you guys can review this (or find someone to review it?) |
|
Did we want to add any test coverage around this new functionality before accepting this PR? (oh and I have poked platform about this impending PR) |
|
I love it, please merge. |
|
This looks good so far, but I think it needs test coverage in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to specify a directory as a source (with additional options to control file pattern matching and recursiveness).
Also added the ability to output the data to a file.
New prefetch format added based on a manifest I was trying to create.
My use case for these changes was that I have several thousand files that I want to create a manifest file for dynamic downloads. So I wanted to run this script once, not thousands of times.