From 585bf7ad778c320979ab1599965b4674aa678a1c Mon Sep 17 00:00:00 2001 From: steve Date: Sun, 12 Jan 2025 15:06:07 +0000 Subject: [PATCH 1/2] fix compilation error with later 3.0.x versions of arduino-esp32 --- src/VGA/VGA.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/VGA/VGA.h b/src/VGA/VGA.h index 0b7a6f6..bf48bfd 100644 --- a/src/VGA/VGA.h +++ b/src/VGA/VGA.h @@ -33,7 +33,7 @@ class VGA : public VGAMode, public VGAPinConfig // TODO This function should be pure virtual, but it is currently implemented with added arguments in children classes virtual bool init(const Mode &mode, const int *pinMap, const int bitCount, const int clockPin = -1) - {} + { return false; } virtual bool init(const Mode &mode, const PinConfig &pinConfig) = 0; From 43c5acb5cd535bbe7ac1cdaa501fe0adeb9301aa Mon Sep 17 00:00:00 2001 From: steve Date: Sun, 12 Jan 2025 15:36:28 +0000 Subject: [PATCH 2/2] bugfix: confusing parameter with method name --- src/I2S/DMABufferDescriptor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/I2S/DMABufferDescriptor.h b/src/I2S/DMABufferDescriptor.h index 3d0a6b6..0d548ce 100644 --- a/src/I2S/DMABufferDescriptor.h +++ b/src/I2S/DMABufferDescriptor.h @@ -105,7 +105,7 @@ class DMABufferDescriptor : protected lldesc_t if (!b) DEBUG_PRINTLN("Failed to alloc DMABufferDescriptor"); b->init(); - if (allocateBuffer) + if (allocBuffer) b->setBuffer(allocateBuffer(bytes, clear, clearValue), bytes); return b; }