Skip to content

Commit 40d8883

Browse files
committed
ALB overtakes ELB R53 - Fix no LB DNS
1 parent 5f15512 commit 40d8883

File tree

1 file changed

+24
-3
lines changed

1 file changed

+24
-3
lines changed

operations/deployment/terraform/aws/bitovi_main.tf

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ module "aws_route53" {
8787
aws_r53_root_domain_deploy = var.aws_r53_root_domain_deploy
8888
aws_r53_enable_cert = var.aws_r53_enable_cert
8989
# ELB
90-
aws_elb_dns_name = try(module.aws_elb[0].aws_elb_dns_name, "")
91-
aws_elb_zone_id = try(module.aws_elb[0].aws_elb_zone_id, "")
90+
aws_elb_dns_name = try(module.aws_lb[0].aws_alb_dns_name,module.aws_elb[0].aws_elb_dns_name,module.ec2[0].instance_public_ip,"")
91+
aws_elb_zone_id = try(module.aws_lb[0].aws_alb_zone_id,module.aws_elb[0].aws_elb_zone_id,module.vpc.preferred_az,"")
9292
# Certs
9393
aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
9494
# Others
@@ -99,9 +99,30 @@ module "aws_route53" {
9999
}
100100
}
101101

102+
#module "aws_route53_lb" {
103+
# source = "../modules/aws/route53"
104+
# count = var.aws_ec2_instance_create && var.aws_r53_enable && var.aws_r53_domain_name != "" && var.aws_alb_create ? 1 : 0
105+
# # R53 values
106+
# aws_r53_domain_name = var.aws_r53_domain_name
107+
# aws_r53_sub_domain_name = var.aws_r53_sub_domain_name
108+
# aws_r53_root_domain_deploy = var.aws_r53_root_domain_deploy
109+
# aws_r53_enable_cert = var.aws_r53_enable_cert
110+
# # ELB
111+
# aws_elb_dns_name = module.aws_lb[0].aws_alb_dns_name
112+
# aws_elb_zone_id = module.aws_lb[0].aws_alb_zone_id
113+
# # Certs
114+
# aws_certificates_selected_arn = var.aws_r53_enable_cert && var.aws_r53_domain_name != "" ? module.aws_certificates[0].selected_arn : ""
115+
# # Others
116+
# fqdn_provided = local.fqdn_provided
117+
#
118+
# providers = {
119+
# aws = aws.r53
120+
# }
121+
#}
122+
102123
module "aws_elb" {
103124
source = "../modules/aws/elb"
104-
count = var.aws_ec2_instance_create && var.aws_elb_create ? 1 : 0
125+
count = var.aws_ec2_instance_create && var.aws_elb_create && !var.aws_alb_create ? 1 : 0
105126
# ELB Values
106127
aws_elb_security_group_name = var.aws_elb_security_group_name
107128
aws_elb_app_port = var.aws_elb_app_port

0 commit comments

Comments
 (0)