Skip to content

Commit 8ef14bd

Browse files
committed
styling fixes
1 parent d558458 commit 8ef14bd

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

service/hook/github/github.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ func transformPullRequestEvent(pullRequest PullRequestEventModel) hookCommon.Tra
344344
if mergeRefUpToDate {
345345
mergeRefBuildParam = unverifiedMergeRefBuildParam
346346
}
347-
if mergeRefUpToDate && *pullRequest.PullRequestInfo.Mergeable == false {
347+
if mergeRefUpToDate && !*pullRequest.PullRequestInfo.Mergeable {
348348
return hookCommon.TransformResultModel{
349349
Error: errors.New("pull Request is not mergeable"),
350350
ShouldSkip: true,
@@ -527,12 +527,12 @@ func transformIssueCommentEvent(eventModel IssueCommentEventModel) hookCommon.Tr
527527
func detectContentTypeAndEventID(header http.Header) (string, string, error) {
528528
contentType := header.Get("Content-Type")
529529
if contentType == "" {
530-
return "", "", errors.New("No Content-Type Header found")
530+
return "", "", errors.New("no Content-Type Header found")
531531
}
532532

533533
ghEvent := header.Get("X-Github-Event")
534534
if ghEvent == "" {
535-
return "", "", errors.New("No X-Github-Event Header found")
535+
return "", "", errors.New("no X-Github-Event Header found")
536536
}
537537

538538
return contentType, ghEvent, nil
@@ -543,7 +543,7 @@ func (hp HookProvider) TransformRequest(r *http.Request) hookCommon.TransformRes
543543
contentType, ghEvent, err := detectContentTypeAndEventID(r.Header)
544544
if err != nil {
545545
return hookCommon.TransformResultModel{
546-
Error: fmt.Errorf("Issue with Headers: %s", err),
546+
Error: fmt.Errorf("issue with Headers: %s", err),
547547
}
548548
}
549549

@@ -596,26 +596,26 @@ func (hp HookProvider) TransformRequest(r *http.Request) hookCommon.TransformRes
596596
}
597597

598598
return hookCommon.TransformResultModel{
599-
Error: fmt.Errorf("Unsupported GitHub event type: %s", ghEvent),
599+
Error: fmt.Errorf("unsupported GitHub event type: %s", ghEvent),
600600
}
601601
}
602602

603603
func decodeEventPayload[T interface{}](r *http.Request, contentType string) (*T, error) {
604604
var eventModel T
605605
if contentType == hookCommon.ContentTypeApplicationJSON {
606606
if err := json.NewDecoder(r.Body).Decode(&eventModel); err != nil {
607-
return nil, fmt.Errorf("Failed to parse request body as JSON: %s", err)
607+
return nil, fmt.Errorf("failed to parse request body as JSON: %s", err)
608608
}
609609
} else if contentType == hookCommon.ContentTypeApplicationXWWWFormURLEncoded {
610610
payloadValue := r.PostFormValue("payload")
611611
if payloadValue == "" {
612612
return nil, fmt.Errorf("failed to parse request body: empty payload")
613613
}
614614
if err := json.NewDecoder(strings.NewReader(payloadValue)).Decode(&eventModel); err != nil {
615-
return nil, fmt.Errorf("Failed to parse payload: %s", err)
615+
return nil, fmt.Errorf("failed to parse payload: %s", err)
616616
}
617617
} else {
618-
return nil, fmt.Errorf("Unsupported Content-Type: %s", contentType)
618+
return nil, fmt.Errorf("unsupported Content-Type: %s", contentType)
619619
}
620620

621621
return &eventModel, nil

0 commit comments

Comments
 (0)