Skip to content

Commit df75a55

Browse files
authored
Also send commit_messages field for PR merge push events (#217)
1 parent ea87e45 commit df75a55

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

service/hook/visualstudioteamservices/visualstudioteamservices.go

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ func transformPushEvent(pushEvent PushEventModel) hookCommon.TransformResultMode
137137
branch := strings.TrimPrefix(pushRef, "refs/heads/")
138138

139139
if len(pushEvent.Resource.Commits) < 1 {
140+
var commitMessage string
140141
commitHash := headRefUpdate.NewObjectID
141142
if commitHash == emptyCommitHash {
142143
// no commits and the (new) commit hash is empty -> this is a delete event,
@@ -147,15 +148,17 @@ func transformPushEvent(pushEvent PushEventModel) hookCommon.TransformResultMode
147148
}
148149
}
149150
if headRefUpdate.OldObjectID == emptyCommitHash {
151+
commitMessage = "Branch created"
150152
// (new) commit hash was not empty, but old one is -> this is a create event,
151153
// without any commits pushed, just the branch created
152154
return hookCommon.TransformResultModel{
153155
TriggerAPIParams: []bitriseapi.TriggerAPIParamsModel{
154156
{
155157
BuildParams: bitriseapi.BuildParamsModel{
156-
Branch: branch,
157-
CommitHash: commitHash,
158-
CommitMessage: "Branch created",
158+
Branch: branch,
159+
CommitHash: commitHash,
160+
CommitMessage: commitMessage,
161+
CommitMessages: []string{commitMessage},
159162
},
160163
},
161164
},
@@ -170,13 +173,15 @@ func transformPushEvent(pushEvent PushEventModel) hookCommon.TransformResultMode
170173
// `git log`, but it does not include it in the hook event,
171174
// only the head ref change.
172175
// So, for now, we'll use the event's detailed message as the commit message.
176+
commitMessage = pushEvent.DetailedMessage.Text
173177
return hookCommon.TransformResultModel{
174178
TriggerAPIParams: []bitriseapi.TriggerAPIParamsModel{
175179
{
176180
BuildParams: bitriseapi.BuildParamsModel{
177-
Branch: branch,
178-
CommitHash: commitHash,
179-
CommitMessage: pushEvent.DetailedMessage.Text,
181+
Branch: branch,
182+
CommitHash: commitHash,
183+
CommitMessage: commitMessage,
184+
CommitMessages: []string{commitMessage},
180185
},
181186
},
182187
},

service/hook/visualstudioteamservices/visualstudioteamservices_test.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -424,9 +424,10 @@ func Test_transformPushEvent(t *testing.T) {
424424
require.Equal(t, []bitriseapi.TriggerAPIParamsModel{
425425
{
426426
BuildParams: bitriseapi.BuildParamsModel{
427-
Branch: "test-branch",
428-
CommitHash: "7c0d90dc542b86747e42ac8f03f794a96ecfc68a",
429-
CommitMessage: "Branch created",
427+
Branch: "test-branch",
428+
CommitHash: "7c0d90dc542b86747e42ac8f03f794a96ecfc68a",
429+
CommitMessage: "Branch created",
430+
CommitMessages: []string{"Branch created"},
430431
},
431432
},
432433
}, hookTransformResult.TriggerAPIParams)
@@ -469,9 +470,10 @@ func Test_transformPushEvent(t *testing.T) {
469470
require.Equal(t, []bitriseapi.TriggerAPIParamsModel{
470471
{
471472
BuildParams: bitriseapi.BuildParamsModel{
472-
Branch: "master",
473-
CommitHash: "7c0d90dc542b86747e42ac8f03f794a96ecfc68a",
474-
CommitMessage: "Author Name pushed 4 commits to branch master of test project\r\n - PR 3: Merge feature/new-branch-test to master 293d9ead ...",
473+
Branch: "master",
474+
CommitHash: "7c0d90dc542b86747e42ac8f03f794a96ecfc68a",
475+
CommitMessage: "Author Name pushed 4 commits to branch master of test project\r\n - PR 3: Merge feature/new-branch-test to master 293d9ead ...",
476+
CommitMessages: []string{"Author Name pushed 4 commits to branch master of test project\r\n - PR 3: Merge feature/new-branch-test to master 293d9ead ..."},
475477
},
476478
},
477479
}, hookTransformResult.TriggerAPIParams)

0 commit comments

Comments
 (0)