Commit 08636a6
Address code review feedback for LTR visual transformations
Simplifies password field visual transformations and adds comprehensive
documentation to clarify usage patterns for future contributors.
Changes:
- Remove unnecessary CompoundVisualTransformation when password is obscured
(bullets are directionally neutral)
- Change ForceLtrVisualTransformation and CompoundVisualTransformation
visibility from private to internal for testability
- Add comprehensive KDoc explaining when to use LTR transformation:
* Apply to technical identifiers (SSN, passport, license, etc.)
* Do NOT apply to locale-dependent text (names, addresses, usernames)
- Add usage examples to CompoundVisualTransformation
- Create comprehensive test suites (39 test cases) to verify offset
mapping correctness and edge case handling
All tests pass and code compiles successfully.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 417726a commit 08636a6
File tree
6 files changed
+680
-19
lines changed- ui/src
- main/kotlin/com/bitwarden/ui/platform/components
- field
- util
- test/kotlin/com/bitwarden/ui/platform/components/util
6 files changed
+680
-19
lines changedLines changed: 1 addition & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
21 | 19 | | |
22 | 20 | | |
23 | 21 | | |
| |||
46 | 44 | | |
47 | 45 | | |
48 | 46 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 47 | + | |
53 | 48 | | |
54 | 49 | | |
55 | 50 | | |
| |||
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 146 | + | |
150 | 147 | | |
151 | 148 | | |
152 | 149 | | |
| |||
Lines changed: 36 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
15 | 48 | | |
16 | | - | |
| 49 | + | |
17 | 50 | | |
18 | 51 | | |
19 | 52 | | |
| |||
Lines changed: 38 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
20 | 52 | | |
21 | | - | |
| 53 | + | |
22 | 54 | | |
23 | 55 | | |
24 | 56 | | |
| |||
38 | 70 | | |
39 | 71 | | |
40 | 72 | | |
41 | | - | |
| 73 | + | |
42 | 74 | | |
43 | 75 | | |
44 | 76 | | |
| |||
0 commit comments