Fix lints

Author: iinuwa

crates/bitwarden-crypto/Cargo.toml

@@ -20,7 +20,7 @@ no-memory-hardening = [] # Disable memory hardening features
 uniffi = [
     "bitwarden-encoding/uniffi",
     "dep:bitwarden-uniffi-error",
-    "dep:uniffi"
+    "dep:uniffi",
 ] # Uniffi bindings
 wasm = ["dep:tsify", "dep:wasm-bindgen"] # WASM support
 

crates/bitwarden-crypto/src/keys/prf.rs

@@ -4,10 +4,8 @@ use crate::{CryptoError, SymmetricCryptoKey, utils::stretch_key};
 ///
 /// The PRF output must be at least 32 bytes long.
 pub fn derive_symmetric_key_from_prf(prf: &[u8]) -> Result<SymmetricCryptoKey, CryptoError> {
-    let (secret, _) = prf
-        .split_at_checked(32)
-        .ok_or_else(|| CryptoError::InvalidKeyLen)?;
-    let secret: [u8; 32] = secret.try_into().unwrap();
+    let (secret, _) = prf.split_at_checked(32).ok_or(CryptoError::InvalidKeyLen)?;
+    let secret: [u8; 32] = secret.try_into().expect("length to be 32 bytes");
     // Don't allow uninitialized PRFs
     if secret.iter().all(|b| *b == b'\0') {
         return Err(CryptoError::ZeroNumber);

crates/bitwarden-crypto/src/store/key_rotation.rs

@@ -56,8 +56,8 @@ pub fn dangerous_get_v2_rotated_account_keys<Ids: KeyIds>(
 /// and the `PublicKey` is protected by the `DownstreamKey`. This setup allows:
 ///
 ///   - Access to `DownstreamKey` by knowing the `UpstreamKey`
-///   - Rotation to a `NewDownstreamKey` by knowing the current `DownstreamKey`, without needing access to
-///     the `UpstreamKey`
+///   - Rotation to a `NewDownstreamKey` by knowing the current `DownstreamKey`, without needing
+///     access to the `UpstreamKey`
 #[derive(Serialize, Deserialize, Debug)]
 #[serde(rename_all = "camelCase", deny_unknown_fields)]
 #[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
@@ -105,7 +105,7 @@ impl RotateableKeySet {
         let encrypted_encapsulation_key = key_pair
             .to_public_key()
             .to_der()?
-            .encrypt_with_key(&downstream_key)?;
+            .encrypt_with_key(downstream_key)?;
 
         Ok(RotateableKeySet {
             encapsulated_downstream_key,