Merge pull request #37 from blockcypher/formatting

Formatting

Author: quentinlesceller

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec)

blockcypher-ruby.gemspec

@@ -1,22 +1,24 @@
+# frozen_string_literal: true
+
 Gem::Specification.new do |s|
   s.name        = 'blockcypher-ruby'
   s.summary     = 'Blockcypher Ruby SDK'
   s.version     = '0.2.6'
   s.licenses    = ['Apache 2.0']
-  s.description = "Ruby library to help you build your crypto application on BlockCypher"
-  s.summary     = "Ruby library to help you build your crypto application on BlockCypher"
-  s.authors     = ["CoinHako", "BlockCypher", "meXBT", 'Gem']
+  s.description = 'Ruby library to help you build your crypto application on BlockCypher'
+  s.summary     = 'Ruby library to help you build your crypto application on BlockCypher'
+  s.authors     = %w[CoinHako BlockCypher meXBT Gem]
   s.email       = 'contact@blockcypher.com'
-  s.files       = Dir["{spec,lib}/**/*"] + %w(LICENSE README.md)
+  s.files       = Dir['{spec,lib}/**/*'] + %w[LICENSE README.md]
   s.homepage    = 'http://www.blockcypher.com'
 
-  s.add_runtime_dependency "bitcoin-ruby", ["~> 0.0.5"]
-  s.add_runtime_dependency "ffi"
-  s.add_development_dependency "bundler", "~> 1.6"
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "activesupport"
-  s.add_development_dependency "vcr"
-  s.add_development_dependency "webmock"
+  s.add_runtime_dependency 'bitcoin-ruby', ['~> 0.0.5']
+  s.add_runtime_dependency 'ffi'
+  s.add_development_dependency 'activesupport'
+  s.add_development_dependency 'bundler', '~> 1.6'
+  s.add_development_dependency 'pry'
+  s.add_development_dependency 'rake'
+  s.add_development_dependency 'rspec'
+  s.add_development_dependency 'vcr'
+  s.add_development_dependency 'webmock'
 end

lib/blockcypher/api.rb

@@ -1,5 +1,6 @@
-module BlockCypher
+# frozen_string_literal: true
 
+module BlockCypher
   V1 = 'v1'
 
   BTC = 'btc'
@@ -13,8 +14,7 @@ module BlockCypher
   TEST_NET_3 = 'test3'
 
   class Api
-
-    class Error < RuntimeError ; end
+    class Error < RuntimeError; end
 
     attr_reader :api_token
 
@@ -59,7 +59,7 @@ def faucet(address, amount)
     ##################
 
     def decode_hex(hex)
-      payload = { 'tx' => hex}
+      payload = { 'tx' => hex }
       api_http_post('/txs/decode', json_payload: payload)
     end
 
@@ -69,10 +69,7 @@ def push_hex(hex)
     end
 
     def send_money(from_address, to_address, satoshi_amount, private_key)
-
-      unless to_address.kind_of? Array
-        to_address = [to_address]
-      end
+      to_address = [to_address] unless to_address.is_a? Array
 
       tx_new = transaction_new([from_address], to_address, satoshi_amount)
 
@@ -115,13 +112,13 @@ def signer(private_key, tosign)
       signatures = []
 
       tosign.each do |to_sign_hex|
-        to_sign_binary = [to_sign_hex].pack("H*")
+        to_sign_binary = [to_sign_hex].pack('H*')
         sig_binary = key.sign(to_sign_binary)
-        sig_hex = sig_binary.unpack("H*").first
+        sig_hex = sig_binary.unpack1('H*')
         signatures << sig_hex
       end
 
-      return signatures
+      signatures
     end
 
     def transaction_new_custom(payload)
@@ -175,23 +172,23 @@ def address_generate
     end
 
     def address_generate_multi(pubkeys, script_type)
-      payload = { 'pubkeys' => pubkeys, 'script_type' => script_type}
+      payload = { 'pubkeys' => pubkeys, 'script_type' => script_type }
       api_http_post('/addrs', json_payload: payload)
     end
 
     def address_details(address, unspent_only: false, limit: 50,
                         before: nil, after: nil, confirmations: nil,
-												omit_wallet_addresses: false, include_confidence:false)
+                        omit_wallet_addresses: false, include_confidence: false)
       query = {
         unspentOnly: unspent_only,
         limit: limit,
         omitWalletAddresses: omit_wallet_addresses,
-				includeConfidence: include_confidence
+        includeConfidence: include_confidence
       }
       query[:before] = before if before
-			query[:after] = after if after
+      query[:after] = after if after
 
-      api_http_get('/addrs/' + address, query: query )
+      api_http_get('/addrs/' + address, query: query)
     end
 
     def address_balance(address, omit_wallet_addresses: false)
@@ -206,12 +203,12 @@ def address_final_balance(address, omit_wallet_addresses: false)
     end
 
     def address_full_txs(address, limit: 10, before: nil, after: nil,
-												 include_hex: false, omit_wallet_addresses: false, include_confidence:false)
+                         include_hex: false, omit_wallet_addresses: false, include_confidence: false)
       query = {
         limit: limit,
         includeHex: include_hex,
         omitWalletAddresses: omit_wallet_addresses,
-				includeConfidence: include_confidence
+        includeConfidence: include_confidence
       }
       query[:before] = before if before
       query[:after] = after if after
@@ -224,7 +221,7 @@ def address_full_txs(address, limit: 10, before: nil, after: nil,
     ##################
 
     def wallet_create(name, addresses)
-      payload = { 'name' => name, 'addresses' => Array(addresses)}
+      payload = { 'name' => name, 'addresses' => Array(addresses) }
       api_http_post('/wallets', json_payload: payload)
     end
 
@@ -244,8 +241,8 @@ def wallet_get_addr(name)
     end
 
     def wallet_delete_addr(name, addresses)
-      addrjoin = addresses.join(";")
-      api_http_delete('/wallets/' + name + '/addresses', query: { address: addrjoin})
+      addrjoin = addresses.join(';')
+      api_http_delete('/wallets/' + name + '/addresses', query: { address: addrjoin })
     end
 
     def wallet_gen_addr(name)
@@ -263,7 +260,7 @@ def wallet_delete(name)
     def event_webhook_subscribe(url, event, options = {})
       payload = {
         url: url,
-        event: event,
+        event: event
       }.merge(options)
 
       api_http_post('/hooks', json_payload: payload)
@@ -295,44 +292,43 @@ def create_forwarding_address(
         destination: destination,
         callback_url: callback_url,
         enable_confirmations: enable_confirmations,
-        mining_fees_satoshis: mining_fees_satoshis,
+        mining_fees_satoshis: mining_fees_satoshis
       }
       api_http_post('/payments', json_payload: payload)
     end
 
-    alias :create_payments_forwarding :create_forwarding_address
+    alias create_payments_forwarding create_forwarding_address
 
     def list_forwarding_addresses
-      api_http_get("/payments")
+      api_http_get('/payments')
     end
 
     def delete_forwarding_address(id)
-      api_http_delete("/payments/" + id)
+      api_http_delete('/payments/' + id)
     end
 
-
     #############
     # Asset API #
     #############
 
     def generate_asset_address
-      api_http_post("/oap/addrs")
+      api_http_post('/oap/addrs')
     end
 
     def issue_asset(from_private, to_address, amount)
-      api_http_post("/oap/issue", json_payload: {
-        from_private: from_private,
-        to_address: to_address,
-        amount: amount
-      })
+      api_http_post('/oap/issue', json_payload: {
+                      from_private: from_private,
+                      to_address: to_address,
+                      amount: amount
+                    })
     end
 
     def transfer_asset(asset_id, from_private, to_address, amount)
       api_http_post("/oap/#{asset_id}/transfer", json_payload: {
-         from_private: from_private,
-         to_address: to_address,
-         amount: amount
-      })
+                      from_private: from_private,
+                      to_address: to_address,
+                      amount: amount
+                    })
     end
 
     def asset_txs(asset_id)
@@ -349,7 +345,7 @@ def api_http_call(http_method, api_path, query, json_payload: nil)
       uri = endpoint_uri(api_path, query)
 
       # Build the connection
-      http    = Net::HTTP.new(uri.host, uri.port)
+      http = Net::HTTP.new(uri.host, uri.port)
       http.use_ssl = true
 
       # Build the Request
@@ -373,16 +369,16 @@ def api_http_call(http_method, api_path, query, json_payload: nil)
 
       # Detect errors/return 204 empty body
       if response_code >= 400
-        raise Error.new(uri.to_s + ' Response:' + response.body)
+        raise Error, uri.to_s + ' Response:' + response.body
       elsif response_code == 204
         return nil
       end
 
       # Process the response
       begin
         json_response = JSON.parse(response.body)
-        return json_response
-      rescue => e
+        json_response
+      rescue StandardError => e
         raise "Unable to parse JSON response #{e.inspect}, #{response.body}"
       end
     end