This repository was archived by the owner on Feb 24, 2022. It is now read-only.
-
Couldn't load subscription status.
- Fork 46
This repository was archived by the owner on Feb 24, 2022. It is now read-only.
Make arcyon Windows compatible #15
Copy link
Copy link
Open
Description
When trying to run arcyon on a Windows environment, you get the error:
$ arcyon
Traceback (most recent call last):
File "c:/Program Files/arcanist/phabricator-tools/bin/arcyon", line 31, in <module>
import aoncmd_arcyon # noqa
File "c:\Program Files\arcanist\phabricator-tools\py\aon\aoncmd_arcyon.py", line 33, in <module>
import aoncmd_gitdiffhelper
File "c:\Program Files\arcanist\phabricator-tools\py\aon\aoncmd_gitdiffhelper.py", line 31, in <module>
import abdt_branch
File "c:\Program Files\arcanist\phabricator-tools\py\abd\abdt_branch.py", line 61, in <module>
import abdt_differ
File "c:\Program Files\arcanist\phabricator-tools\py\abd\abdt_differ.py", line 32, in <module>
import phlgit_diff
File "c:\Program Files\arcanist\phabricator-tools\py\phl\phlgit_diff.py", line 26, in <module>
import phlsys_fs
File "c:\Program Files\arcanist\phabricator-tools\py\phl\phlsys_fs.py", line 33, in <module>
import fcntl
ImportError: No module named fcntlIt seems that fcntl is used to get file lock permissions, but no fcntl module exists for Windows. It's worth noting that arcanist uses the EDITOR config variable to get blocking sessions (PhutilInteractiveEditor.php) so it is possible, just not with the fcntl module.
Worth noting, I have no idea if this is the only code that's not Windows compatible, so this request may be more than just what I've listed here.
Metadata
Metadata
Assignees
Labels
No labels