Skip to content

ksql has undeclared build-time dependencies #117

@neersighted

Description

@neersighted

A Poetry user ran into undeclared build-time dependencies in ksql -- namely, pip is imported in setup.py but there is no declaration of this dependency:

ksql-python/setup.py

Lines 10 to 13 in 6161b48

if LooseVersion(pip.__version__) >= "10.0.0":
from pip._internal.req import parse_requirements
else:
from pip.req import parse_requirements

If you want to reliably import pip during a build, you need to declare the dependency somewhere. The modern way to do this (as described at that link) is to list everything in build-system.requires of your pyproject.toml; however, you can also use the deprecated setup_requires argument to setup() if you prefer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions