Skip to content

Commit 5396510

Browse files
authored
Merge pull request jdorn#757 from jneiluj/jdorn#670-Fix-headerTemplate-Spectre-theme
Fix headerTemplate for Spectre theme
2 parents e820871 + 66120bf commit 5396510

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/themes/spectre.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -318,9 +318,8 @@ export class spectreTheme extends AbstractTheme {
318318
getTab (span, tabId) {
319319
const el = document.createElement('a')
320320
el.classList.add('btn', 'btn-secondary', 'btn-block')
321-
el.id = tabId
322-
el.innerHTML = span.innerHTML
323-
321+
el.setAttribute('href', `#${tabId}`)
322+
el.appendChild(span)
324323
return el
325324
}
326325

@@ -332,8 +331,9 @@ export class spectreTheme extends AbstractTheme {
332331

333332
/* Spectre needs an a tag inside the tab item, not a span */
334333
const a = document.createElement('a')
335-
a.href = '#'
336-
a.innerHTML = span.innerHTML
334+
a.setAttribute('href', `#${tabId}`)
335+
a.appendChild(span)
336+
337337
el.appendChild(a)
338338
return el
339339
}

0 commit comments

Comments
 (0)