From a262281a7f0c3c8eee315ea63b8b5d6329f5c6f7 Mon Sep 17 00:00:00 2001 From: Igor Date: Fri, 6 Jun 2025 11:47:42 +0200 Subject: [PATCH 1/2] a very simple fix --- tests/test_convert.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_convert.py b/tests/test_convert.py index dc584f53..ce0e17cf 100644 --- a/tests/test_convert.py +++ b/tests/test_convert.py @@ -52,9 +52,9 @@ def _test_array_recode(array_with_index_and_table): @conftest.override_sparsify("partial") def test_array_recode_sparsify_partial(array_with_index_and_table): - return _test_array_recode(array_with_index_and_table) + _test_array_recode(array_with_index_and_table) @conftest.override_sparsify("none") def test_array_recode_sparsify_none(array_with_index_and_table): - return _test_array_recode(array_with_index_and_table) + _test_array_recode(array_with_index_and_table) From 48ef318cf54777f20bca17b0e9fb9bb27e9f6949 Mon Sep 17 00:00:00 2001 From: Igor Date: Fri, 6 Jun 2025 11:52:17 +0200 Subject: [PATCH 2/2] this should return none --- tests/test_convert.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_convert.py b/tests/test_convert.py index ce0e17cf..c5f4ed14 100644 --- a/tests/test_convert.py +++ b/tests/test_convert.py @@ -44,7 +44,7 @@ def _test_array_recode(array_with_index_and_table): # XXX(leon): we don't yet support native qdb -> np.ndarray with dtype `null-terminated binary` (S). I don't think we # should ever do this, but we do need it for input. That's why we can't test this right now, because we # can't do it full circle. - return True + return (idx2, xs2) = m.test_array_recode(ctype, dtype, (idx1, xs1)) assert_indexed_arrays_equal((idx1, xs1), (idx2, xs2))