Skip to content

Add MMC isotherm by Nfor 2010 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add MMC isotherm by Nfor 2010 #191

wants to merge 1 commit into from

Conversation

@ronald-jaepel
Copy link
Contributor

@ronald-jaepel ronald-jaepel commented Apr 25, 2024

This PR adds the Mixed Mode Chromatography isotherm by Nfor et al 2010.

ToDos:

  • Implement Isotherm Flux
  • Implement Isotherm Jacobian
    • First draft is implemented, but breaks atm, needs a second look
  • Run tests (once jacobian is implemented)
  • Documentation:
    • Add Interface documentation
    • Add model documentation
    • Link to the isotherm documentation pages at the correct sites
    • Test build and validate documentation

@ronald-jaepel
Copy link
Contributor Author

ronald-jaepel commented Apr 25, 2024

cadet_MMC.zip
Here's a windows binary of the current state. This is usable with .discretization.use_analytic_jacobian = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

binding model

Projects

CADET Repositories
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ronald-jaepel @jbreue16