CW1011-Allow-users-to-view-bitcoin-amounts-in-sats #2678
+686
−458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt formatting logic
…vailability check
…isplay preferences across buy/sell flow and UI adjustments
…formatting crypto amounts in various display modes
…n-amounts-in-sats # Conflicts: # cw_bitcoin/lib/electrum_wallet.dart # cw_core/lib/crypto_currency.dart # lib/view_model/send/output.dart
…d introduce `AmountParsingProxy` for unified crypto amount handling across the app
…s handling with `AmountParsingProxy` integration for unified crypto processing
…gProxy` and remove debug print in `exchange_view_model`
…arsingProxy`, remove redundant dependencies across view models and adjust related imports
…tup to simplify dependency management [skip ci]
OmarHatem28
requested changes
Dec 4, 2025
…n-sats # Conflicts: # lib/view_model/send/output.dart
OmarHatem28
reviewed
Dec 7, 2025
| final amount_ = _enteredAmount / bestRate; | ||
| _cryptoNumberFormat.maximumFractionDigits = receiveMaxDigits; | ||
| receiveAmount = _appStore.amountParsingProxy.getCryptoOutputAmount( | ||
| _cryptoNumberFormat.maximumFractionDigits = depositMaxDigits; |
Contributor
There was a problem hiding this comment.
so is this still needed?
This reverts commit 6debdaa.
OmarHatem28
reviewed
Dec 7, 2025
| @action | ||
| void _updateCryptoAmount() { | ||
| try { | ||
| final decimals = min(20, cryptoCurrencyHandler().decimals); |
Contributor
There was a problem hiding this comment.
the reason for this change is that nano has higher decimal points so it was failing to parse with nano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give users the option to show amounts in sats
Pull Request - Checklist