Fix GitHub Copilot suggestions and simplify test setup

calliostro · calliostro · commit c20591784982 · 2025-09-08T19:09:25.000+02:00
- Improve parameter validation in __call method to handle null/non-array inputs
- Add error handling for preg_split operations using null coalescing operator
- Optimize test performance by reducing test string length from 1000 to 100 chars
- Simplify PHPUnit configuration by removing coverage requirements from default config
- Remove xdebug warning for users running composer test without coverage setup
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -4,12 +4,10 @@
          colors="true"
          testdox="true"
          cacheDirectory=".phpunit.cache"
-         beStrictAboutCoverageMetadata="true"
          beStrictAboutOutputDuringTests="true"
          executionOrder="depends,defects"
-         failOnWarning="true"
+         failOnWarning="false"
          failOnRisky="true"
-         requireCoverageMetadata="true"
          displayDetailsOnIncompleteTests="true"
          displayDetailsOnSkippedTests="true">
   <testsuites>
@@ -22,12 +20,6 @@
       <directory>src</directory>
     </include>
   </source>
-  <coverage>
-    <report>
-      <html outputDirectory="coverage"/>
-      <text outputFile="php://stdout"/>
-    </report>
-  </coverage>
   <php>
     <ini name="error_reporting" value="E_ALL"/>
     <ini name="memory_limit" value="-1"/>
diff --git a/src/DiscogsApiClient.php b/src/DiscogsApiClient.php
@@ -77,7 +77,7 @@ public function __construct(GuzzleClient $client)
      */
     public function __call(string $method, array $arguments): array
     {
-        $params = $arguments[0] ?? [];
+        $params = is_array($arguments[0] ?? null) ? $arguments[0] : [];
 
         return $this->callOperation($method, $params);
     }
@@ -139,7 +139,7 @@ private function callOperation(string $method, array $params): array
     private function convertMethodToOperation(string $method): string
     {
         // Split a camelCase into parts
-        $parts = preg_split('/(?=[A-Z])/', $method, -1, PREG_SPLIT_NO_EMPTY);
+        $parts = preg_split('/(?=[A-Z])/', $method, -1, PREG_SPLIT_NO_EMPTY) ?: [];
 
         if (!$parts) {
             return $method;
diff --git a/tests/Unit/DiscogsApiClientTest.php b/tests/Unit/DiscogsApiClientTest.php
@@ -384,8 +384,8 @@ public function testMethodCallWithNullParameters(): void
             new Response(200, [], $this->jsonEncode(['success' => true]))
         );
 
-        // Test method call with null as parameters (edge case)
-        // @phpstan-ignore-next-line - Testing edge case
+        // Test method call with null as parameters - should be converted to empty array
+        // @phpstan-ignore-next-line - Testing parameter validation
         $result = $this->client->search(null);
 
         $this->assertEquals(['success' => true], $result);
@@ -442,8 +442,8 @@ public function testPregSplitEdgeCaseHandling(): void
         $method = $reflection->getMethod('convertMethodToOperation');
         $method->setAccessible(true);
 
-        // Test with an extremely long method name to potentially trigger edge cases
-        $longMethodName = str_repeat('A', 1000) . 'Get';
+        // Test with a long method name (100 characters) to potentially trigger edge cases
+        $longMethodName = str_repeat('A', 100) . 'Get';
         $result = $method->invokeArgs($this->client, [$longMethodName]);
         // This should still work, converting the long name properly
         $this->assertIsString($result);

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public function __construct(GuzzleClient $client)`
`77`	`77`	`*/`
`78`	`78`	`public function __call(string $method, array $arguments): array`
`79`	`79`	`{`
`80`		`- $params = $arguments[0] ?? [];`
	`80`	`+ $params = is_array($arguments[0] ?? null) ? $arguments[0] : [];`
`81`	`81`
`82`	`82`	`return $this->callOperation($method, $params);`
`83`	`83`	`}`
`@@ -139,7 +139,7 @@ private function callOperation(string $method, array $params): array`
`139`	`139`	`private function convertMethodToOperation(string $method): string`
`140`	`140`	`{`
`141`	`141`	`// Split a camelCase into parts`
`142`		`- $parts = preg_split('/(?=[A-Z])/', $method, -1, PREG_SPLIT_NO_EMPTY);`
	`142`	`+ $parts = preg_split('/(?=[A-Z])/', $method, -1, PREG_SPLIT_NO_EMPTY) ?: [];`
`143`	`143`
`144`	`144`	`if (!$parts) {`
`145`	`145`	`return $method;`