-
Notifications
You must be signed in to change notification settings - Fork 4
Description
Problem description
PR #40 was merged, and the tag r1.1 created. I'm aware that there wasn't a review requested, but let me share my observations anyway, so that the issues can be corrected within the next alpha release
Expected behavior
Issues get corrected with the next pre-release
Alternative solution
Some issues might be not relevant for pre-releases and can be ignored.
Additional context
Observed issues:
Location: documentation/API_documentation/iot-network-optimization-API-Readiness-Checklist.md#L3
Issue: Title references "kyc-match vwip" instead of "iot-network-optimization v0.1.0-alpha.1"
Location: code/Test_definitions/iot-network-optimization-power-saving.feature
Issue: No API resource URL statements present
API Location: code/API_definitions/iot-network-optimization.yaml:163
Test Locations: iot-network-optimization-power-saving.feature:27,48,69
Issue: API declares 202 Accepted for POST operation, tests expect 200 OK
Location: code/API_definitions/iot-network-optimization.yaml:36-38
Issue: Link uses /blob/main/ instead of /blob/r1.1/ for release tag
Impact: Documentation link not locked to release version
Fix: Change link from /blob/main/ to /blob/r1.1/
Test expects: org.camaraproject.iot.dta-status-changed-event (line 146)
API defines: org.camaraproject.iot-network-optimization-notification.v1.power-saving
The latter is also not matching the API name (iot-network-optimization, not iot-network-optimization-notification.