Users that fail to be created cause downstream issues with key imports

[jasonwbarnett]

Version:

v2.4.6

Environment:

• Redhat 7
• Chef Server Core v13.2.0

Scenario:

Restore from backup, e.g. knife ec restore --with-key-sql --with-user-sql

Steps to Reproduce:

Put an invalid email address in any of the users you're restoring.

Expected Result:

I would expect the process to safely handle when a user failed to be created and not error out on the key import process.

Actual Result:

An error is thrown and exits the process immediately

[jasonwbarnett]

The issue is here

knife-ec-backup/lib/chef/knife/ec_key_import.rb

Line 132 in ed16dea

db[:users].where(:username => d['name']).first[:id]

The user is not found and then #[](:id) is called on nil and throws an exception.