Skip to content

Latest commit

 

History

History
1418 lines (984 loc) · 68.8 KB

File metadata and controls

1418 lines (984 loc) · 68.8 KB

TravelBanker - Developer Guide

1. Setting up

1.1. Prerequisites

  1. JDK 1.8.0_60 or later

    ℹ️
    Having any Java 8 version is not enough.
    This app will not work with earlier versions of Java 8.
  2. IntelliJ IDE

    ℹ️
    IntelliJ by default has Gradle and JavaFx plugins installed.
    Do not disable them. If you have disabled them, go to File > Settings > Plugins to re-enable them.

1.2. Setting up the project in your computer

  1. Fork this repo, and clone the fork to your computer

  2. Open IntelliJ (if you are not in the welcome screen, click File > Close Project to close the existing project dialog first)

  3. Set up the correct JDK version for Gradle

    1. Click Configure > Project Defaults > Project Structure

    2. Click New…​ and find the directory of the JDK

  4. Click Import Project

  5. Locate the build.gradle file and select it. Click OK

  6. Click Open as Project

  7. Click OK to accept the default settings

  8. Open a console and run the command gradlew processResources (Mac/Linux: ./gradlew processResources). It should finish with the BUILD SUCCESSFUL message.
    This will generate all resources required by the application and tests.

1.3. Verifying the setup

  1. Run the seedu.address.MainApp and try a few commands

  2. Run the tests to ensure they all pass.

1.4. Configurations to do before writing code

1.4.1. Configuring the coding style

This project follows oss-generic coding standards. IntelliJ’s default style is mostly compliant with ours but it uses a different import order from ours. To rectify,

  1. Go to File > Settings…​ (Windows/Linux), or IntelliJ IDEA > Preferences…​ (macOS)

  2. Select Editor > Code Style > Java

  3. Click on the Imports tab to set the order

    • For Class count to use import with '*' and Names count to use static import with '*': Set to 999 to prevent IntelliJ from contracting the import statements

    • For Import Layout: The order is import static all other imports, import java.*, import javax.*, import org.*, import com.*, import all other imports. Add a <blank line> between each import

Optionally, you can follow the UsingCheckstyle.adoc document to configure Intellij to check style-compliance as you write code.

1.4.2. Updating documentation to match your fork

After forking the repo, links in the documentation will still point to the CS2103JAN2018/main repo. If you plan to develop this as a separate product (i.e. instead of contributing to the CS2103JAN2018/main) , you should replace the URL in the variable repoURL in DeveloperGuide.adoc and UserGuide.adoc with the URL of your fork.

1.4.3. Setting up CI

Set up Travis to perform Continuous Integration (CI) for your fork. See UsingTravis.adoc to learn how to set it up.

After setting up Travis, you can optionally set up coverage reporting for your team fork (see UsingCoveralls.adoc).

ℹ️
Coverage reporting could be useful for a team repository that hosts the final version but it is not that useful for your personal fork.

Optionally, you can set up AppVeyor as a second CI (see UsingAppVeyor.adoc).

ℹ️
Having both Travis and AppVeyor ensures your App works on both Unix-based platforms and Windows-based platforms (Travis is Unix-based and AppVeyor is Windows-based)

1.4.4. Getting started with coding

When you are ready to start coding,

  1. Get some sense of the overall design by reading Section 2.1, “Architecture”.

  2. Take a look at Appendix A, Suggested Programming Tasks to Get Started.

2. Design

2.1. Architecture

Architecture
Figure 1. Architecture Diagram

The Architecture Diagram given above explains the high-level design of the App. Given below is a quick overview of each component.

💡
The .pptx files used to create diagrams in this document can be found in the diagrams folder. To update a diagram, modify the diagram in the pptx file, select the objects of the diagram, and choose Save as picture.

Main has only one class called MainApp. It is responsible for,

  • At app launch: Initializes the components in the correct sequence, and connects them up with each other.

  • At shut down: Shuts down the components and invokes cleanup method where necessary.

Commons represents a collection of classes used by multiple other components. Two of those classes play important roles at the architecture level.

  • EventsCenter : This class (written using Google’s Event Bus library) is used by components to communicate with other components using events (i.e. a form of Event Driven design)

  • LogsCenter : Used by many classes to write log messages to the App’s log file.

The rest of the App consists of four components.

  • UI: The UI of the App.

  • Logic: The command executor.

  • Model: Holds the data of the App in-memory.

  • Storage: Reads data from, and writes data to, the hard disk.

Each of the four components

  • Defines its API in an interface with the same name as the Component.

  • Exposes its functionality using a {Component Name}Manager class.

For example, the Logic component (see the class diagram given below) defines it’s API in the Logic.java interface and exposes its functionality using the LogicManager.java class.

LogicClassDiagram
Figure 2. Class Diagram of the Logic Component

Events-Driven nature of the design

The Sequence Diagram below shows how the components interact for the scenario where the user issues the command delete 1.

SDforDeletePerson
Figure 3. Component interactions for delete 1 command (part 1)
ℹ️
Note how the Model simply raises a TravelBankerChangedEvent when the accounting book data are changed, instead of asking the Storage to save the updates to the hard disk.

The diagram below shows how the EventsCenter reacts to that event, which eventually results in the updates being saved to the hard disk and the status bar of the UI being updated to reflect the 'Last Updated' time.

SDforDeletePersonEventHandling
Figure 4. Component interactions for delete 1 command (part 2)
ℹ️
Note how the event is propagated through the EventsCenter to the Storage and UI without Model having to be coupled to either of them. This is an example of how this Event Driven approach helps us reduce direct coupling between components.

The sections below give more details of each component.

2.2. UI component

UiClassDiagram
Figure 5. Structure of the UI Component

API : Ui.java

The UI consists of a MainWindow that is made up of parts e.g.CommandBox, ResultDisplay, PersonListPanel, StatusBarFooter, BrowserPanel etc. All these, including the MainWindow, inherit from the abstract UiPart class.

The UI component uses JavaFx UI framework. The layout of these UI parts are defined in matching .fxml files that are in the src/main/resources/view folder. For example, the layout of the MainWindow is specified in MainWindow.fxml

The UI component,

  • Executes user commands using the Logic component.

  • Binds itself to some data in the Model so that the UI can auto-update when data in the Model change.

  • Responds to events raised from various parts of the App and updates the UI accordingly.

2.3. Logic component

LogicClassDiagram
Figure 6. Structure of the Logic Component
LogicCommandClassDiagram
Figure 7. Structure of Commands in the Logic Component. This diagram shows finer details concerning XYZCommand and Command in Figure 6, “Structure of the Logic Component”

API : Logic.java

  1. Logic uses the TravelBankerParser class to parse the user command.

  2. This results in a Command object which is executed by the LogicManager.

  3. The command execution can affect the Model (e.g. adding a person) and/or raise events.

  4. The result of the command execution is encapsulated as a CommandResult object which is passed back to the Ui.

Given below is the Sequence Diagram for interactions within the Logic component for the execute("delete 1") API call.

DeletePersonSdForLogic
Figure 8. Interactions Inside the Logic Component for the delete 1 Command

2.4. Model component

ModelClassDiagram
Figure 9. Structure of the Model Component

API : Model.java

The Model,

  • stores a UserPref object that represents the user’s preferences.

  • stores the accounting book data.

  • exposes an unmodifiable ObservableList<Person> that can be 'observed' e.g. the UI can be bound to this list so that the UI automatically updates when the data in the list change.

  • does not depend on any of the other three components.

2.5. Storage component

StorageClassDiagram
Figure 10. Structure of the Storage Component

API : Storage.java

The Storage component,

  • can save UserPref objects in json format and read it back.

  • can save the accounting book data in xml format and read it back.

2.6. Common classes

Classes used by multiple components are in the seedu.TravelBanker.commons package.

3. Implementation

This section describes some noteworthy details on how certain features are implemented.

3.1. List Positive/Negative feature

3.1.1. Current Implementation

The positive/negative feature is faciliatated by two new methods ListPositiveBalanceCommand and ListNegativeBalanceCommand which both reside inside commands. It supports listing out the people with negative balances and positive balances. This is helpful because it will allow the phonebook user to quickly list out people who they owe and who owes them money.

For the new class I created ListPositiveBalanceCommand, this is the code for execute:

public CommandResult execute() {
    model.updateFilteredPersonList(isPositiveBalance());
    return new CommandResult(MESSAGE_SUCCESS);
}

As you can see from the code snippet, we update the filtered person list using a new function isPositiveBalance().

isPositiveBalance() is implemented as follows:

public Predicate<Person> isPositiveBalance(){
    return a -> a.getMoney().balance >= 0;
}

The negative balance works the same way just checking to see if the balance is less than 0.

3.1.2. Alternatives Considered

For an alternative way, I considered creating a new empty list positiveList and then adding to positiveList whenever the balance is greater than 0. Then I was going to display positive list. However this did not end up working because I noticed that updating the flitered list needed a predicate function as a paramter which my approach would not have. Therefore I had to consider a different approach that involved a predicate function.

3.1.3. Future Additions

I can further refine the function to be much more powerful in filtering and listing out people. For instance, I could allow it to list people with whose names start with a specific letter because in an large addressbook, the user might want to quickly go through the addressbook, not ones who just have a postiive or negative balance.

The function is a predicate function that checks to see if a.getMoney().balance>=0 because the function updateFilteredPersonList() takes in a predicate parameter. In our function we see the predicate check to see if the person’s money balance is positive and if so, it will be returned.

3.2. Undo/Redo feature

3.2.1. Current Implementation

The undo/redo mechanism is facilitated by an UndoRedoStack, which resides inside LogicManager. It supports undoing and redoing of commands that modifies the state of the accounting book (e.g. add, edit). Such commands will inherit from UndoableCommand.

UndoRedoStack only deals with UndoableCommands. Commands that cannot be undone will inherit from Command instead. The following diagram shows the inheritance diagram for commands:

LogicCommandClassDiagram

As you can see from the diagram, UndoableCommand adds an extra layer between the abstract Command class and concrete commands that can be undone, such as the DeleteCommand. Note that extra tasks need to be done when executing a command in an undoable way, such as saving the state of the accounting book before execution. UndoableCommand contains the high-level algorithm for those extra tasks while the child classes implements the details of how to execute the specific command. Note that this technique of putting the high-level algorithm in the parent class and lower-level steps of the algorithm in child classes is also known as the template pattern.

Commands that are not undoable are implemented this way:

public class ListCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... list logic ...
    }
}

With the extra layer, the commands that are undoable are implemented this way:

public abstract class UndoableCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... undo logic ...

        executeUndoableCommand();
    }
}

public class DeleteCommand extends UndoableCommand {
    @Override
    public CommandResult executeUndoableCommand() {
        // ... delete logic ...
    }
}

Suppose that the user has just launched the application. The UndoRedoStack will be empty at the beginning.

The user executes a new UndoableCommand, delete 5, to delete the 5th person in the accounting book. The current state of the accounting book is saved before the delete 5 command executes. The delete 5 command will then be pushed onto the undoStack (the current state is saved together with the command).

UndoRedoStartingStackDiagram

As the user continues to use the program, more commands are added into the undoStack. For example, the user may execute add n/David …​ to add a new person.

UndoRedoNewCommand1StackDiagram
ℹ️
If a command fails its execution, it will not be pushed to the UndoRedoStack at all.

The user now decides that adding the person was a mistake, and decides to undo that action using undo.

We will pop the most recent command out of the undoStack and push it back to the redoStack. We will restore the accounting book to the state before the add command executed.

UndoRedoExecuteUndoStackDiagram
ℹ️
If the undoStack is empty, then there are no other commands left to be undone, and an Exception will be thrown when popping the undoStack.

The following sequence diagram shows how the undo operation works:

UndoRedoSequenceDiagram

The redo does the exact opposite (pops from redoStack, push to undoStack, and restores the accounting book to the state after the command is executed).

ℹ️
If the redoStack is empty, then there are no other commands left to be redone, and an Exception will be thrown when popping the redoStack.

The user now decides to execute a new command, clear. As before, clear will be pushed into the undoStack. This time the redoStack is no longer empty. It will be purged as it no longer make sense to redo the add n/David command (this is the behavior that most modern desktop applications follow).

UndoRedoNewCommand2StackDiagram

Commands that are not undoable are not added into the undoStack. For example, list, which inherits from Command rather than UndoableCommand, will not be added after execution:

UndoRedoNewCommand3StackDiagram

The following activity diagram summarize what happens inside the UndoRedoStack when a user executes a new command:

UndoRedoActivityDiagram

3.2.2. Design Considerations

Aspect: Implementation of UndoableCommand
  • Alternative 1 (current choice): Add a new abstract method executeUndoableCommand()

    • Pros: We will not lose any undone/redone functionality as it is now part of the default behaviour. Classes that deal with Command do not have to know that executeUndoableCommand() exist.

    • Cons: Hard for new developers to understand the template pattern.

  • Alternative 2: Just override execute()

    • Pros: Does not involve the template pattern, easier for new developers to understand.

    • Cons: Classes that inherit from UndoableCommand must remember to call super.execute(), or lose the ability to undo/redo.

Aspect: How undo & redo executes
  • Alternative 1 (current choice): Saves the entire accounting book.

    • Pros: Easy to implement.

    • Cons: May have performance issues in terms of memory usage.

  • Alternative 2: Individual command knows how to undo/redo by itself.

    • Pros: Will use less memory (e.g. for delete, just save the person being deleted).

    • Cons: We must ensure that the implementation of each individual command are correct.

Aspect: Type of commands that can be undone/redone
  • Alternative 1 (current choice): Only include commands that modifies the accounting book (add, clear, edit).

    • Pros: We only revert changes that are hard to change back (the view can easily be re-modified as no data are * lost).

    • Cons: User might think that undo also applies when the list is modified (undoing filtering for example), * only to realize that it does not do that, after executing undo.

  • Alternative 2: Include all commands.

    • Pros: Might be more intuitive for the user.

    • Cons: User have no way of skipping such commands if he or she just want to reset the state of the address * book and not the view. Additional Info: See our discussion here.

Aspect: Data structure to support the undo/redo commands
  • Alternative 1 (current choice): Use separate stack for undo and redo

    • Pros: Easy to understand for new Computer Science student undergraduates to understand, who are likely to be * the new incoming developers of our project.

    • Cons: Logic is duplicated twice. For example, when a new command is executed, we must remember to update * both HistoryManager and UndoRedoStack.

  • Alternative 2: Use HistoryManager for undo/redo

    • Pros: We do not need to maintain a separate stack, and just reuse what is already in the codebase.

    • Cons: Requires dealing with commands that have already been undone: We must remember to skip these commands. Violates Single Responsibility Principle and Separation of Concerns as HistoryManager now needs to do two * different things.

3.3. Balance Feature

The balance feature is implemented by the BalanceCommand class, which resides in the Logic component. It extends the Command class and is not an undoable or re-doable command, similar to list. The balance command relies on the incorporation of the [MONEY] field, which stores the amount that a specific contact owes to the user, or the amount the user owes to the said contact if the balance is negative.

The following class diagram shows shows where where the BalanceCommand is implemented.

BalanceCommand   Class Diagram

Commands that cannot be undone such as BalanceCommand are implemented like this:

public class ListCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... list logic ...
    }
}

The following sequence diagram shows how the balance command works.

BalanceCommandSequenceDiagram

Suppose that the user just launched the application. The TravelBanker will load his contacts and the amount of money owed by/to each will be shown to the screen. The user simply types balance or b, which will be interpreted by the TravelBook Parser. Once the command is parsed, it will return a new BalanceCommand, which LogicManager will call command. LogicManager will then call the execute() function on command. This method calls on getBalancefromTravelBanker gets a Persons list through model, and thus gets to manipulate the values in the m/[MONEY] field of the current accounting book. It then adds all of them and displays to the feedback to the user by returning a CommandResult with the found data as argument.

The following activity diagram summarizes the execution of the balance command.

BalanceCommandActivityDiagram

3.3.1. Design Considerations

Aspect: Making balance not an undoable or re-doable command.
  • Alternative 1 (current choice): Make balance not an undoable command**.

  • Pros: There was no need to make balance a re-doable or undoable command since it serves a purpose similar to list: it only displays information found in TravelBanker, but does not alter it. Thus, the user will not have any issues with this command should he make a mistake: it does not write any data.

  • Cons: No significant disadvantage.

  • Alternative 2: make balance an undoable command.

  • Pros: No serious advantage, as explained in Alternative 1. Since the command does not aim to modify data, this method is not applicable.

  • Cons: Extra layer of complexity that does not give any significant benefit

Aspect: How balance command result is displayed.
  • Alternative 1 (current choice) : Pass the result as a string in the feedback to user.

  • Pros : Easy to implement and serves the purpose perfectly.

  • Cons : Value cannot be singled out to apply UI effects, such as colors.

  • Alternative 2 : Single out result to make it modifiable by UI.

  • Pros: Allow for more pleasant user experience.

  • Cons: More difficult to implement and not much value added.

3.4. Add/Delete/Show Item Field

3.4.1. Current Implementation

The implementation of the item field touches three components: Model, Logic, and Storage.

Model

For Model component, Person class was modified and added with exactly one UniqueItemList, where each UniqueItemList consists of multiple Item`s. For each `Item, it has two strings as private attributes, namely the ItemName ()

A partial class diagram of the models can be seen below:

itemDiagram

The isValidName and isValidValue methods are used to make sure that the user input conforms to the regex for a name and a floating point number:

Logic

In the Logic component, three new command, ItemShowCommand ItemAddCommand ItemDeleteCommand, have been added. ItemAddCommand and ItemDeleteCommand are undoable, because these two commands are implemented by replacing the old person in the ModelManager with a newly modified person.

    model.updatePerson(personToEdit, editedPerson);
ℹ️
In ItemAddCommand, editedPerson is created from personToEdit with a newly added item. In ItemDeleteCommand, however, editedPerson is created from personToEdit by deleting a specific item.
Storage

Storage was also changed in the development of this feature, as new XML elements had to be stored and parsed using the xml storage system.

The three types of new XML elements are <items> <name> and <value>, and they are organised as following:

    <persons>
        <name>John Doe</name>
        <phone>98765432</phone>
        ......
        <items>
            <name>taxi fare</name>
            <value>10.5</value>
        </items>
        <items>
            <name>his treat in PizzaHut</name>
            <value>23.0</value>
        </items>
    </persons>

To conform to the required changes, the XmlAdaptedPerson class is modified. Additionally, a new class XmlAdaptedItem is created .

The new XmlAdaptedPerson class is as follows:

public class XmlAdaptedPerson {
    @XmlElement(required = true)
    private String name;
    @XmlElement(required = true)
    private String phone;
    @XmlElement(required = true)
    private String email;
    @XmlElement(required = true)
    private String address;
    @XmlElement
    private String balance;
    @XmlElement
    private List<XmlAdaptedTag> tagged = new ArrayList<>();


    @XmlElement
    private List<XmlAdaptedItem> items = new ArrayList<>();

    ......
}

Here is the new XmlAdaptedItem class:

public class XmlAdaptedItem {

    @XmlElement(required = true)
    private String name;
    @XmlElement(required = true)
    private String value;

    ......
}

3.5. sort Feature

The sort feature is implemented by the sortCommand class, which resides in the Logic component. When sortCommand is executed, it would call the Model component (UniquePersonList) to sort the person list. To specify the sorting order and the keyword to be sorted, two strings would be passed as parameters. In support of different keyword, Class Name, Phone, Email, Address, Money were add with a compareTo method for the creation of comparators.

The sortCommand supports sorting of the filteredList (i.e. list that comes from FindCommand execution).

In the current implementation, the sorted result would not be store in the storage.

Commands that cannot be undone such as sortCommand are implemented like this:

public class sortCommand extends Command {
    @Override
    public CommandResult execute() {
        // ... sort logic ...
        return new CommandResult(MESSAGE_SUCCESS);
    }
}

The following activity diagram summarizes the execution of the sort command.

SortCommand Activity Diagram

3.6. [Proposed] Data Encryption

{Explain here how the data encryption feature will be implemented}

3.7. Add/Edit Money Field

3.7.1. Current Implementation

The implementation of the money field spanned four components: Model, Logic, Storage and UI.

Model

In terms of the Model component, a new Money model was created and the Person and Addressbook models required modifications to integrate the new Money model. The Money model was written to be consistent with the existing Person attribute models like "Email" and "Phone".

A class diagram of the models can be seen below:

MoneyClassDiagram

The most important part of the Money model is the constructor:

public Money(String balance) {
    requireNonNull(balance);
    checkArgument(isValidMoney(balance), MESSAGE_MONEY_CONSTRAINTS);
    this.balance = Double.parseDouble(balance);
    this.value = balance;
}

The constructor was implemented using two properties: Double balance and String value This is because the money value is often used as a string for display and as a double for calculations and comparisons. The trade-off here was to either store it as just a Double or a String, and cast the value into the right type when needed, or store the value as both a Double and a String. The first option forgoes time performance to provide better space performance and keep one single source of truth for each Money object. The second option however provides better time performance, but falls short on space and source of truth data integrity. Our team decided to take the second option as data integrity issues can be mitigated through comprehensive testing, and because time performance is more important than space complexity at this point time.

The other notable parts of the Money model are the validation checking function isValidMoney and the equals function.

The isValidMoney function is used to make sure that the user input conforms to the regex for a number:

public static boolean isValidMoney(String test) {
    return test.matches(MONEY_VALIDATION_REGEX);
}

The equals function is mostly used for testing, and provides a way to check if two Money objects have equal values. The function makes sure that the objects are of the same type, and share the same value property:

public boolean equals(Object other) {
    return other == this // short circuit if same object
            || (other instanceof Money // instanceof handles nulls
            && this.value.equals(((Money) other).value)); // state check
}

There were also small modifications to the AddressBook and Person models. These changes mainly have to do with adding Money as a property of Person, and making sure the getters and setters work appropriately for that property.

Logic

In the context of the Logic component, the "add" and "edit" components had to be modified. In addition, some parser logic had to be modified in order to work with the new money parameter. To be more specific, one of the major changes here was the parseMoney function which is used to parse the input from the user into a Money object:

public static Money parseMoney(String money) throws IllegalValueException {
    requireNonNull(money);
    String trimmedMoney = money.trim();
    if (!Money.isValidMoney(trimmedMoney)) {
        throw new IllegalValueException(Money.MESSAGE_MONEY_CONSTRAINTS);
    }
    return new Money(trimmedMoney);
}
ℹ️
In this implmentation, if an invalid input is received for the money parameter, which is anything that isn’t a Double, an IllegalValueExcpetion is thrown.

This implementation was chosen as to stay consistent with the rest of the existing fields. In other words, this parseMoney function is comparable to the parseEmail or parsePhone functions, in order to maintain consistency in parser logic.

Storage

Storage was also changed in the development of this feature, as a new parameter had to be stored and parsed using the xml storage system.

The logic for parsing the stored data is very similar to the parsing logic for user input:

if (!Money.isValidMoney(this.balance)) {
    throw new IllegalValueException(Money.MESSAGE_MONEY_CONSTRAINTS);
}
final Money balance = new Money(this.balance);

Then this money object is used to create the Person object:

return new Person(name, phone, email, address, balance, tags);

Again, this implementation was chosen to be consistent with the existing logic of parsing the stored xml.

UI

The changes in the UI were minor, and simply added the money field to the PersonCard UI component:

<Label fx:id="money" styleClass="cell_small_label" text="\$money" />

3.8. Logging

We are using java.util.logging package for logging. The LogsCenter class is used to manage the logging levels and logging destinations.

  • The logging level can be controlled using the logLevel setting in the configuration file (See Section 3.9, “Configuration”)

  • The Logger for a class can be obtained using LogsCenter.getLogger(Class) which will log messages according to the specified logging level

  • Currently log messages are output through: Console and to a .log file.

Logging Levels

  • SEVERE : Critical problem detected which may possibly cause the termination of the application

  • WARNING : Can continue, but with caution

  • INFO : Information showing the noteworthy actions by the App

  • FINE : Details that is not usually noteworthy but may be useful in debugging e.g. print the actual list instead of just its size

3.9. Configuration

Certain properties of the application can be controlled (e.g App name, logging level) through the configuration file (default: config.json).

4. Documentation

We use asciidoc for writing documentation.

ℹ️
We chose asciidoc over Markdown because asciidoc, although a bit more complex than Markdown, provides more flexibility in formatting.

4.1. Editing Documentation

See UsingGradle.adoc to learn how to render .adoc files locally to preview the end result of your edits. Alternatively, you can download the AsciiDoc plugin for IntelliJ, which allows you to preview the changes you have made to your .adoc files in real-time.

4.2. Publishing Documentation

See UsingTravis.adoc to learn how to deploy GitHub Pages using Travis.

4.3. Converting Documentation to PDF format

We use Google Chrome for converting documentation to PDF format, as Chrome’s PDF engine preserves hyperlinks used in webpages.

Here are the steps to convert the project documentation files to PDF format.

  1. Follow the instructions in UsingGradle.adoc to convert the AsciiDoc files in the docs/ directory to HTML format.

  2. Go to your generated HTML files in the build/docs folder, right click on them and select Open withGoogle Chrome.

  3. Within Chrome, click on the Print option in Chrome’s menu.

  4. Set the destination to Save as PDF, then click Save to save a copy of the file in PDF format. For best results, use the settings indicated in the screenshot below.

chrome save as pdf
Figure 11. Saving documentation as PDF files in Chrome

5. Testing

5.1. Running Tests

There are three ways to run tests.

💡
The most reliable way to run tests is the 3rd one. The first two methods might fail some GUI tests due to platform/resolution-specific idiosyncrasies.

Method 1: Using IntelliJ JUnit test runner

  • To run all tests, right-click on the src/test/java folder and choose Run 'All Tests'

  • To run a subset of tests, you can right-click on a test package, test class, or a test and choose Run 'ABC'

Method 2: Using Gradle

  • Open a console and run the command gradlew clean allTests (Mac/Linux: ./gradlew clean allTests)

ℹ️
See UsingGradle.adoc for more info on how to run tests using Gradle.

Method 3: Using Gradle (headless)

Thanks to the TestFX library we use, our GUI tests can be run in the headless mode. In the headless mode, GUI tests do not show up on the screen. That means the developer can do other things on the Computer while the tests are running.

To run tests in headless mode, open a console and run the command gradlew clean headless allTests (Mac/Linux: ./gradlew clean headless allTests)

5.2. Types of tests

We have two types of tests:

  1. GUI Tests - These are tests involving the GUI. They include,

    1. System Tests that test the entire App by simulating user actions on the GUI. These are in the systemtests package.

    2. Unit tests that test the individual components. These are in seedu.address.ui package.

  2. Non-GUI Tests - These are tests not involving the GUI. They include,

    1. Unit tests targeting the lowest level methods/classes.
      e.g. seedu.address.commons.StringUtilTest

    2. Integration tests that are checking the integration of multiple code units (those code units are assumed to be working).
      e.g. seedu.address.storage.StorageManagerTest

    3. Hybrids of unit and integration tests. These test are checking multiple code units as well as how the are connected together.
      e.g. seedu.address.logic.LogicManagerTest

5.3. Troubleshooting Testing

Problem: HelpWindowTest fails with a NullPointerException.

  • Reason: One of its dependencies, UserGuide.html in src/main/resources/docs is missing.

  • Solution: Execute Gradle task processResources.

6. Dev Ops

6.1. Build Automation

See UsingGradle.adoc to learn how to use Gradle for build automation.

6.2. Continuous Integration

We use Travis CI and AppVeyor to perform Continuous Integration on our projects. See UsingTravis.adoc and UsingAppVeyor.adoc for more details.

6.3. Coverage Reporting

We use Coveralls to track the code coverage of our projects. See UsingCoveralls.adoc for more details.

6.4. Documentation Previews

When a pull request has changes to asciidoc files, you can use Netlify to see a preview of how the HTML version of those asciidoc files will look like when the pull request is merged. See UsingNetlify.adoc for more details.

6.5. Making a Release

Here are the steps to create a new release.

  1. Update the version number in MainApp.java.

  2. Generate a JAR file using Gradle.

  3. Tag the repo with the version number. e.g. v0.1

  4. Create a new release using GitHub and upload the JAR file you created.

6.6. Managing Dependencies

A project often depends on third-party libraries. For example, accounting book depends on the Jackson library for XML parsing. Managing these dependencies can be automated using Gradle. For example, Gradle can download the dependencies automatically, which is better than these alternatives.
a. Include those libraries in the repo (this bloats the repo size)
b. Require developers to download those libraries manually (this creates extra work for developers)

Appendix A: Suggested Programming Tasks to Get Started

Suggested path for new programmers:

  1. First, add small local-impact (i.e. the impact of the change does not go beyond the component) enhancements to one component at a time. Some suggestions are given in Section A.1, “Improving each component”.

  2. Next, add a feature that touches multiple components to learn how to implement an end-to-end feature across all components. Section A.2, “Creating a new command: remark explains how to go about adding such a feature.

A.1. Improving each component

Each individual exercise in this section is component-based (i.e. you would not need to modify the other components to get it to work).

Logic component

Scenario: You are in charge of logic. During dog-fooding, your team realize that it is troublesome for the user to type the whole command in order to execute a command. Your team devise some strategies to help cut down the amount of typing necessary, and one of the suggestions was to implement aliases for the command words. Your job is to implement such aliases.

💡
Do take a look at Section 2.3, “Logic component” before attempting to modify the Logic component.
  1. Add a shorthand equivalent alias for each of the individual commands. For example, besides typing clear, the user can also type c to remove all persons in the list.

    • Hints

    • Solution

      • Modify the switch statement in TravelBankerParser#parseCommand(String) such that both the proper command word and alias can be used to execute the same intended command.

      • Add new tests for each of the aliases that you have added.

      • Update the user guide to document the new aliases.

      • See this PR for the full solution.

Model component

Scenario: You are in charge of model. One day, the logic-in-charge approaches you for help. He wants to implement a command such that the user is able to remove a particular tag from everyone in the accounting book, but the model API does not support such a functionality at the moment. Your job is to implement an API method, so that your teammate can use your API to implement his command.

💡
Do take a look at Section 2.4, “Model component” before attempting to modify the Model component.
  1. Add a removeTag(Tag) method. The specified tag will be removed from everyone in the accounting book.

    • Hints

      • The Model and the TravelBanker API need to be updated.

      • Think about how you can use SLAP to design the method. Where should we place the main logic of deleting tags?

      • Find out which of the existing API methods in TravelBanker and Person classes can be used to implement the tag removal logic. TravelBanker allows you to update a person, and Person allows you to update the tags.

    • Solution

      • Implement a removeTag(Tag) method in TravelBanker. Loop through each person, and remove the tag from each person.

      • Add a new API method deleteTag(Tag) in ModelManager. Your ModelManager should call TravelBanker#removeTag(Tag).

      • Add new tests for each of the new public methods that you have added.

      • See this PR for the full solution.

        • The current codebase has a flaw in tags management. Tags no longer in use by anyone may still exist on the TravelBanker. This may cause some tests to fail. See issue #753 for more information about this flaw.

        • The solution PR has a temporary fix for the flaw mentioned above in its first commit.

Ui component

Scenario: You are in charge of ui. During a beta testing session, your team is observing how the users use your accounting book application. You realize that one of the users occasionally tries to delete non-existent tags from a contact, because the tags all look the same visually, and the user got confused. Another user made a typing mistake in his command, but did not realize he had done so because the error message wasn’t prominent enough. A third user keeps scrolling down the list, because he keeps forgetting the index of the last person in the list. Your job is to implement improvements to the UI to solve all these problems.

💡
Do take a look at Section 2.2, “UI component” before attempting to modify the UI component.
  1. Use different colors for different tags inside person cards. For example, friends tags can be all in brown, and colleagues tags can be all in yellow.

    Before

    getting started ui tag before

    After

    getting started ui tag after
    • Hints

      • The tag labels are created inside the PersonCard constructor (new Label(tag.tagName)). JavaFX’s Label class allows you to modify the style of each Label, such as changing its color.

      • Use the .css attribute -fx-background-color to add a color.

      • You may wish to modify DarkTheme.css to include some pre-defined colors using css, especially if you have experience with web-based css.

    • Solution

      • You can modify the existing test methods for PersonCard 's to include testing the tag’s color as well.

      • See this PR for the full solution.

        • The PR uses the hash code of the tag names to generate a color. This is deliberately designed to ensure consistent colors each time the application runs. You may wish to expand on this design to include additional features, such as allowing users to set their own tag colors, and directly saving the colors to storage, so that tags retain their colors even if the hash code algorithm changes.

  2. Modify NewResultAvailableEvent such that ResultDisplay can show a different style on error (currently it shows the same regardless of errors).

    Before

    getting started ui result before

    After

    getting started ui result after
  3. Modify the StatusBarFooter to show the total number of people in the accounting book.

    Before

    getting started ui status before

    After

    getting started ui status after
    • Hints

      • StatusBarFooter.fxml will need a new StatusBar. Be sure to set the GridPane.columnIndex properly for each StatusBar to avoid misalignment!

      • StatusBarFooter needs to initialize the status bar on application start, and to update it accordingly whenever the accounting book is updated.

    • Solution

Storage component

Scenario: You are in charge of storage. For your next project milestone, your team plans to implement a new feature of saving the accounting book to the cloud. However, the current implementation of the application constantly saves the accounting book after the execution of each command, which is not ideal if the user is working on limited internet connection. Your team decided that the application should instead save the changes to a temporary local backup file first, and only upload to the cloud after the user closes the application. Your job is to implement a backup API for the accounting book storage.

💡
Do take a look at Section 2.5, “Storage component” before attempting to modify the Storage component.
  1. Add a new method backupTravelBanker(ReadOnlyTravelBanker), so that the accounting book can be saved in a fixed temporary location.

A.2. Creating a new command: remark

By creating this command, you will get a chance to learn how to implement a feature end-to-end, touching all major components of the app.

Scenario: You are a software maintainer for TravelBanker, as the former developer team has moved on to new projects. The current users of your application have a list of new feature requests that they hope the software will eventually have. The most popular request is to allow adding additional comments/notes about a particular contact, by providing a flexible remark field for each contact, rather than relying on tags alone. After designing the specification for the remark command, you are convinced that this feature is worth implementing. Your job is to implement the remark command.

A.2.1. Description

Edits the remark for a person specified in the INDEX.
Format: remark INDEX r/[REMARK]

Examples:

  • remark 1 r/Likes to drink coffee.
    Edits the remark for the first person to Likes to drink coffee.

  • remark 1 r/
    Removes the remark for the first person.

A.2.2. Step-by-step Instructions

[Step 1] Logic: Teach the app to accept 'remark' which does nothing

Let’s start by teaching the application how to parse a remark command. We will add the logic of remark later.

Main:

  1. Add a RemarkCommand that extends UndoableCommand. Upon execution, it should just throw an Exception.

  2. Modify TravelBankerParser to accept a RemarkCommand.

Tests:

  1. Add RemarkCommandTest that tests that executeUndoableCommand() throws an Exception.

  2. Add new test method to TravelBankerParserTest, which tests that typing "remark" returns an instance of RemarkCommand.

[Step 2] Logic: Teach the app to accept 'remark' arguments

Let’s teach the application to parse arguments that our remark command will accept. E.g. 1 r/Likes to drink coffee.

Main:

  1. Modify RemarkCommand to take in an Index and String and print those two parameters as the error message.

  2. Add RemarkCommandParser that knows how to parse two arguments, one index and one with prefix 'r/'.

  3. Modify TravelBankerParser to use the newly implemented RemarkCommandParser.

Tests:

  1. Modify RemarkCommandTest to test the RemarkCommand#equals() method.

  2. Add RemarkCommandParserTest that tests different boundary values for RemarkCommandParser.

  3. Modify TravelBankerParserTest to test that the correct command is generated according to the user input.

[Step 3] Ui: Add a placeholder for remark in PersonCard

Let’s add a placeholder on all our PersonCard s to display a remark for each person later.

Main:

  1. Add a Label with any random text inside PersonListCard.fxml.

  2. Add FXML annotation in PersonCard to tie the variable to the actual label.

Tests:

  1. Modify PersonCardHandle so that future tests can read the contents of the remark label.

[Step 4] Model: Add Remark class

We have to properly encapsulate the remark in our Person class. Instead of just using a String, let’s follow the conventional class structure that the codebase already uses by adding a Remark class.

Main:

  1. Add Remark to model component (you can copy from Address, remove the regex and change the names accordingly).

  2. Modify RemarkCommand to now take in a Remark instead of a String.

Tests:

  1. Add test for Remark, to test the Remark#equals() method.

[Step 5] Model: Modify Person to support a Remark field

Now we have the Remark class, we need to actually use it inside Person.

Main:

  1. Add getRemark() in Person.

  2. You may assume that the user will not be able to use the add and edit commands to modify the remarks field (i.e. the person will be created without a remark).

  3. Modify SampleDataUtil to add remarks for the sample data (delete your TravelBanker.xml so that the application will load the sample data when you launch it.)

[Step 6] Storage: Add Remark field to XmlAdaptedPerson class

We now have Remark s for Person s, but they will be gone when we exit the application. Let’s modify XmlAdaptedPerson to include a Remark field so that it will be saved.

Main:

  1. Add a new Xml field for Remark.

Tests:

  1. Fix invalidAndValidPersonTravelBanker.xml, typicalPersonsTravelBanker.xml, validTravelBanker.xml etc., such that the XML tests will not fail due to a missing <remark> element.

[Step 6b] Test: Add withRemark() for PersonBuilder

Since Person can now have a Remark, we should add a helper method to PersonBuilder, so that users are able to create remarks when building a Person.

Tests:

  1. Add a new method withRemark() for PersonBuilder. This method will create a new Remark for the person that it is currently building.

  2. Try and use the method on any sample Person in TypicalPersons.

[Step 7] Ui: Connect Remark field to PersonCard

Our remark label in PersonCard is still a placeholder. Let’s bring it to life by binding it with the actual remark field.

Main:

  1. Modify PersonCard's constructor to bind the Remark field to the Person 's remark.

Tests:

  1. Modify GuiTestAssert#assertCardDisplaysPerson(…​) so that it will compare the now-functioning remark label.

[Step 8] Logic: Implement RemarkCommand#execute() logic

We now have everything set up…​ but we still can’t modify the remarks. Let’s finish it up by adding in actual logic for our remark command.

Main:

  1. Replace the logic in RemarkCommand#execute() (that currently just throws an Exception), with the actual logic to modify the remarks of a person.

Tests:

  1. Update RemarkCommandTest to test that the execute() logic works.

A.2.3. Full Solution

See this PR for the step-by-step solution.

Appendix B: Product Scope

Target user profile:

  • has a need to manage a significant number of contacts

  • prefer desktop apps over other types

  • can type fast

  • prefers typing over mouse input

  • is reasonably comfortable using CLI apps

  • has a need to manage finances with fellow contacts

  • has a need to keep track of personal balance

  • has a need to keep track of transactions between contacts

  • travels with a group and lends money/borrows money

  • has a need of finding nearby financial institutions to repay contacts.

Value proposition:

  • manage contacts faster than a typical mouse/GUI driven app

  • manage your informal financial transactions accurately than relying on memory.

  • manage your finances in a more organized manner than relying on a text-editing app, spreadsheet, or memory.

  • update your cumulative total automatically, which removes the need of re-adding the numbers every time a new transaction is added, as seen in traditional book-keeping methods.

  • find a nearby ATM as soon as a contact is loaded, which removes the need to switch apps when wanting to settle a debt.

  • list the contacts that owe you money or to which you owe money, thus removing the need to manually filter out the contacts you are looking for.

  • lists all the contacts according to specified tags, removing the need to identify amounts owed by groups of people manually.

B.1. Feature contribution

  • Artsiom Skliar

    • Major Enhancement: Incorporate map functionality to the TravelBanker. MapCommand shows the nearest ATM from the person’s location. Also, incorporating balance and min commands, which calculates your overall balance as registered in TravelBanker. This value will tell the user if he owes more money than he’s borrowed or vice-versa. This is essential to the product as TravelBanker relies on the need of the user to keep track of his informal finances efficiently and accurately. The ability to see view your overall balance is thus necessary as it provides insight to the user on his general financial situation. The min and max commands contribute to this goal by listing the largest amounts owed and lent. The map functionality also shows the user how he can settle his debts quickly.

    • Minor Enhancement: created aliases for every command received by TravelBanker to increase its efficiency. This is important to the product as it aims to be quick and efficient. Shortcuts for every command (except exit to avoid accidents) allows for a quicker and smoother user experience, thus making book-keeping quick and easy. Incorporate a searchtag command to list only people carrying specific tags.

  • Eric Zhou

    • Major Enhancement: incorporating various listing features which will can filter the list to list out people who owe you a negative amount or a positive amount. This is essential to the product as a user will be able to quickly see who owes them money or who they owe money to. The ability to quickly filter out the list important because in big lists, it might not be the easiest to see what each person owes. With the feature, it increases efficiency for large addressbooks.

    • Minor Enhancement: added negative value allowance for balance to allow people to see the total amount they owe or need to be paid. This is important to the product as people will not always just owe money, sometimes people might need to pay the user, this feature allows that to be accounted for.

    • Minor Enhancement: case insensitivty of commands. This aims to help add ease to the user because the user will not need to type commands in specific way so Add and add will both add a new person.

  • Chen Chongsong

    • Major Enhancement: Implementing a new model called "item" field, which records all items related to a person in the contact list. An "item" has its name and its money value. For example, someone may owe the user an item called "taxiFare" and worth "100" dollars. ItemShowCommand, ItemAddCommand, ItemDeleteCommand are implemented, and the user is able to check items, add items and delete them. The storage XML format has been modified accordingly. This new feature is important because this allows the user to check reasons for owing money, in case the user forgets them.

    • Minor Enhancement: implementing a SortCommand to sort contact list according to balance, name, etc. If name sorted, the user would be able to search for certain person quickly and alphebatically. This is useful because sometimes the user cannot remember the exact names, and therefore, fail to search names with the FindCommand. If balance sorted, the user would be enabled to decide the order of returning money in the future. For example, the user can choose to firstly return money to "small creditors" (because the user owes little money to them, and he can pay them off easily)

  • Prian Kuhanandan

    • Major Enhancement: Implementing the money field, and allowing for existing commands to use the field such as the add and edit commands. This is important because this allows for all the money related features that are essential to our use cases, such as the balance feature.

    • Minor Enhancement: Create a new command to identify the person that owes the user the most money. This is important to the product, because the user needs easy ways to interact with the money field that we have added. This is one minor way to use the field and will provide the user with a lot of value as it will help with locating his or her biggest debtor.

Appendix C: User Stories

Priorities: High (must have) - * * *, Medium (nice to have) - * *, Low (unlikely to have) - *

Priority As a …​ I want to …​ So that I can…​

* * *

new user

see usage instructions

refer to instructions when I forget how to use the App

* * *

user

add a new person

* * *

user

delete a person

remove entries that I no longer need

* * *

user

find a person by name

locate details of persons without having to go through the entire list

* *

user

hide private contact details by default

minimize chance of someone else seeing them by accident

*

user with many persons in the accounting book

sort persons by name

locate a person easily

* *

user

redo or undo a command I just typed in

* * *

user

add/update/settle an amount of money that a contact owes me

* * *

user

check my overall balance

* * *

user

see which contacts owe me money

* * *

user

see to which of my contacts do I owe money

* *

user

see which contact owes me the most money.

* *

user

see to which contact I owe the most money.

* * *

user

see which contact owes me the most money

* *

user

see a list of people with specific tags

have an overview of the money a group owes me

*

user

see the address of a user

* *

user

see for which items/reasons do I owe a contact / a contact owes me

* *

user

add an item/reason under a specified person

* *

user

delete an item/reason from a specified person

*

user

choose the balance the currency that I am owed

*

user

convert my balance into a different currency

*

user

calculate the amount I am owed/I owe with an applied interest rate

* * *

user

have a map functionality

find the nearest ATM to settle my accounts

*

user

sort the contact list according to my wishes

*

user

split a bill evenly among multiple people

*

user

remove certain tags from a person

Appendix D: Use Cases

(For all use cases below, the System is the TravelBanker and the Actor is the user, unless specified otherwise)

Use case: Delete person

MSS

  1. User requests to list persons

  2. TravelBanker shows a list of persons

  3. User requests to delete a specific person in the list

  4. TravelBanker deletes the person

    Use case ends.

Extensions

  • 2a. The list is empty.

    Use case ends.

  • 3a. The given index is invalid.

    • 3a1. TravelBanker shows an error message.

      Use case resumes at step 2.

Use case: To Split a Bill Among Multiple People

MSS

  1. User requests to new a bill

  2. TravelBanker shows the new bill

  3. User requests selects who the bill will be splited among

  4. TravelBanker shows who the bill will be splited among in the contact details

    Use case ends.

Extensions

  • 1a. Specified people does not exist.

    • 1a1. TravelBanker shows an error message.

      Use case resumes at step 2.

Use case: To See Who Owes Me Money

MSS

  1. User requests to see people who owes the user Money

  2. TravelBanker shows the list of people

    Use case ends.

Extensions

  • 1a. No people owe the user money.

    • 1a1. TravelBanker shows an message showing that the list is empty.

      == Non Functional Requirements

      1. Should work on any mainstream OS as long as it has Java 1.8.0_60 or higher installed.

      2. Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.

      3. A user with above average typing speed for regular English text (i.e. not code, not system admin commands) should be able to accomplish most of the tasks faster using commands than using the mouse.

      4. The system should respond within 3 seconds, even for more intensive procedures such as balance calculation.

      5. The system should update its records immediately after the user makes an update.

      6. The system should provide helpful and clear messages to the user when errors occur.

      7. The system should preserve all data and user preferences when software updates are installed.

Appendix E: Glossary

Mainstream OS

Windows, Linux, Unix, OS-X

Private contact detail

A contact detail that is not meant to be shared with others

Appendix F: Product Survey

Product Name

Author: …​

Pros:

  • …​

  • …​

Cons:

  • …​

  • …​

Appendix G: Instructions for Manual Testing

Given below are instructions to test the app manually.

ℹ️
These instructions only provide a starting point for testers to work on; testers are expected to do more exploratory testing.

G.1. Launch and Shutdown

  1. Initial launch

    1. Download the jar file and copy into an empty folder

    2. Double-click the jar file
      Expected: Shows the GUI with a set of sample contacts. The window size may not be optimum.

  2. Saving window preferences

    1. Resize the window to an optimum size. Move the window to a different location. Close the window.

    2. Re-launch the app by double-clicking the jar file.
      Expected: The most recent window size and location is retained.

{ more test cases …​ }

G.2. Deleting a person

  1. Deleting a person while all persons are listed

    1. Prerequisites: List all persons using the list command. Multiple persons in the list.

    2. Test case: delete 1
      Expected: First contact is deleted from the list. Details of the deleted contact shown in the status message. Timestamp in the status bar is updated.

    3. Test case: delete 0
      Expected: No person is deleted. Error details shown in the status message. Status bar remains the same.

    4. Other incorrect delete commands to try: delete, delete x (where x is larger than the list size) {give more}
      Expected: Similar to previous.

{ more test cases …​ }

G.3. Saving data

  1. Dealing with missing/corrupted data files

    1. {explain how to simulate a missing/corrupted file and the expected behavior}

{ more test cases …​ }