diff --git a/lib/redmine_omniauth_saml.rb b/lib/redmine_omniauth_saml.rb index 8b3029d..77814ea 100644 --- a/lib/redmine_omniauth_saml.rb +++ b/lib/redmine_omniauth_saml.rb @@ -92,8 +92,6 @@ def validate_configuration! :idp_sso_target_url, :idp_cert_fingerprint, :name_identifier_format, - :signout_url, - :idp_slo_target_url, :name_identifier_value, :attribute_mapping ].each do |k| raise "Redmine::OmiauthSAML.configure requires that saml.#{k} to be setted" unless saml[k] diff --git a/lib/redmine_omniauth_saml/account_controller_patch.rb b/lib/redmine_omniauth_saml/account_controller_patch.rb index 3296cad..77fa963 100644 --- a/lib/redmine_omniauth_saml/account_controller_patch.rb +++ b/lib/redmine_omniauth_saml/account_controller_patch.rb @@ -141,7 +141,7 @@ def sp_logout_request if not settings[:signout_url] logger.info "SLO IdP Endpoint not found in settings, executing then a normal logout'" saml_logout_user - redirect home_path + redirect_to home_path else # Since we created a new SAML request, save the transaction_id diff --git a/sample-saml-initializers.rb b/sample-saml-initializers.rb index 6e20213..3a19040 100644 --- a/sample-saml-initializers.rb +++ b/sample-saml-initializers.rb @@ -1,12 +1,13 @@ Redmine::OmniAuthSAML::Base.configure do |config| config.saml = { - :assertion_consumer_service_url => "http://redmine.example.com", # The redmine application hostname - :issuer => "sso_issuer", # The issuer name + :assertion_consumer_service_url => "https://redmine.example.com/auth/saml/callback", # The Redmine callback URL + :issuer => "https://redmine.example.com/auth/saml/metadata", # The entity ID / issuer name :idp_sso_target_url => "http://sso.desarrollo.unlp.edu.ar/saml2/idp/SSOService.php", # SSO login endpoint - :idp_cert_fingerprint => "certificate fingerprint", # SSO ssl certificate fingerprint + :idp_cert_fingerprint => "certificate fingerprint", # SSO SSL certificate SHA-1 fingerprint :name_identifier_format => "urn:oasis:names:tc:SAML:2.0:nameid-format:persistent", - :signout_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php?ReturnTo=", - :idp_slo_target_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php", + # SLS is not currently supported in the 3.x branch. + #:signout_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php?ReturnTo=", + #:idp_slo_target_url => "http://sso.example.com/saml2/idp/SingleLogoutService.php", :name_identifier_value => "mail", # Which redmine field is used as name_identifier_value for SAML logout :attribute_mapping => { # How will we map attributes from SSO to redmine attributes