V4 (#8)

* disconnect signals on destroy

* fetch: add missing JSON.parse error handling

* remove 'hover' flag on buttons

* bump compatible shell version

* rename onDestroy to something more unique

* fix deprecated byte array usage

* avoid storing global Soup Client

* make icon buttons more stylish

* fix version checker for v40

* code cleanup

* Make: fix local installation

* make settings gtk 4 compatible

* update translations

* set refresh keys array instead single string comparisons

* validate gitlab account config, add onlyOwnedProjects flag

* gitlab api: use onlyOwned from settings

* settings: add onlyOwnedProjects and use CellRendererToggle

* update translations

* bumped version

* updated readme

Author: cinatic

Makefile

@@ -75,7 +75,7 @@ package: $(BUILD_DIR)
 install: build
 	rm -rf $(INSTALL_DIR)
 	mkdir -p $(INSTALL_DIR)
-	cp -r $(BUILD_DIR)/* $(INSTALL_DIR)
+	cp -r $(BUILD_DIR)/${SRC_DIR}/* $(INSTALL_DIR)
 
 clean:
 	rm -f $(COMPILED_SCHEMAS) $(MO_FILES)

README.md

@@ -15,6 +15,11 @@ Either install it:
 - via EGS https://extensions.gnome.org/extension/3535/gitlab-extension/
 - Or download latest release: https://github.com/cinatic/gitlab-extension/releases/latest
 
+### Quick Start
+Create a ***Profile access token*** in your profile settings https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html 
+and use it to create a new account entry in gitlab extension settings `Account Grid`.
+
+
 ## Data Source
 The data is fetched from the official GitLab API https://docs.gitlab.com/ee/api/. 
 The API has some *limitions*, e.g. it only returns domain specific data. 

gitlab-extension@infinicode.de/components/buttons/iconButton.js

@@ -10,7 +10,7 @@ var IconButton = GObject.registerClass({}, class IconButton extends St.Button {
       reactive: true,
       can_focus: true,
       track_hover: true,
-      style_class: 'icon-button ' + (style_class || ''),
+      style_class: 'icon-button button ' + (style_class || ''),
       y_align: Clutter.ActorAlign.CENTER,
       ...props
     })

gitlab-extension@infinicode.de/components/cards/commitCard.js

@@ -14,8 +14,7 @@ var CommitCard = GObject.registerClass({}, class CommitCard extends St.Button {
     super._init({
       style_class: 'card message commit-card',
       can_focus: true,
-      x_expand: true,
-      hover: true
+      x_expand: true
     })
 
     this.cardItem = commitItem

gitlab-extension@infinicode.de/components/cards/pipelineCard.js

@@ -14,8 +14,7 @@ var PipelineCard = GObject.registerClass({}, class PipelineCard extends St.Butto
     super._init({
       style_class: 'card message pipeline-card',
       can_focus: true,
-      x_expand: true,
-      hover: true
+      x_expand: true
     })
 
     this.cardItem = pipelineItem

gitlab-extension@infinicode.de/components/cards/projectCard.js

@@ -14,8 +14,7 @@ var ProjectCard = GObject.registerClass({}, class ProjectCard extends St.Button
     super._init({
       style_class: 'card message project-card',
       can_focus: true,
-      x_expand: true,
-      hover: true
+      x_expand: true
     })
 
     this.cardItem = projectItem

gitlab-extension@infinicode.de/components/gitlab/projectSelectButtons.js

@@ -11,12 +11,14 @@ var ProjectSelectButtons = GObject.registerClass({}, class ProjectSelectButtons
       style_class: 'project-select-buttons'
     })
 
-    Settings.connect('changed', (value, key) => {
+    this._settingsChangedId = Settings.connect('changed', (value, key) => {
       if (key === 'gitlab-accounts' || key === 'selected-gitlab-account-index') {
         this._sync()
       }
     })
 
+    this.connect('destroy', this._onDestroy.bind(this))
+
     this._sync()
   }
 
@@ -34,7 +36,7 @@ var ProjectSelectButtons = GObject.registerClass({}, class ProjectSelectButtons
 
       const gitlabAccountButton = new St.Button({
         style_class: `message button ${additionalStyleClasses}`,
-        label: gitlabAccount.name,
+        label: gitlabAccount.name
       })
 
       gitlabAccountButton.connect('clicked', () => {
@@ -44,4 +46,10 @@ var ProjectSelectButtons = GObject.registerClass({}, class ProjectSelectButtons
       this.add_child(gitlabAccountButton)
     })
   }
+
+  _onDestroy () {
+    if (this._settingsChangedId) {
+      Settings.disconnect(this._settingsChangedId)
+    }
+  }
 })

gitlab-extension@infinicode.de/components/screenWrapper/screenWrapper.js

@@ -1,4 +1,4 @@
-const { Clutter, GObject, St } = imports.gi
+const { GObject, St } = imports.gi
 
 const ExtensionUtils = imports.misc.extensionUtils
 const Me = ExtensionUtils.getCurrentExtension()

gitlab-extension@infinicode.de/components/screens/projectsScreen/projectsScreen.js

@@ -9,18 +9,31 @@ const { FlatList } = Me.imports.components.flatList.flatList
 const { ProjectSelectButtons } = Me.imports.components.gitlab.projectSelectButtons
 const { ProjectCard } = Me.imports.components.cards.projectCard
 const { SearchBar } = Me.imports.components.searchBar.searchBar
-const { Settings } = Me.imports.helpers.settings
+
+const {
+  Settings,
+  GITLAB_ACCOUNTS,
+  SELECTED_GITLAB_ACCOUNT_INDEX
+} = Me.imports.helpers.settings
+
 const { Translations } = Me.imports.helpers.translations
 
 const GitLabService = Me.imports.services.gitlab
 
+const SETTINGS_KEYS_TO_REFRESH = [
+  GITLAB_ACCOUNTS,
+  SELECTED_GITLAB_ACCOUNT_INDEX
+]
+
 var ProjectsScreen = GObject.registerClass({}, class ProjectsScreen extends St.BoxLayout {
   _init () {
     super._init({
       style_class: 'screen projects-screen',
       vertical: true
     })
 
+    this._settingsChangedId = null
+
     const searchBar = new SearchBar()
     this._list = new FlatList()
 
@@ -39,8 +52,8 @@ var ProjectsScreen = GObject.registerClass({}, class ProjectsScreen extends St.B
 
     searchBar.connect('text-change', (sender, searchText) => this._filter_results(searchText))
 
-    Settings.connect('changed', (value, key) => {
-      if (key === 'gitlab-accounts' || key === 'selected-gitlab-account-index') {
+    this._settingsChangedId = Settings.connect('changed', (value, key) => {
+      if (SETTINGS_KEYS_TO_REFRESH.includes(key)) {
         this._loadData()
       }
 
@@ -54,6 +67,8 @@ var ProjectsScreen = GObject.registerClass({}, class ProjectsScreen extends St.B
       }
     }))
 
+    this.connect('destroy', this._onDestroy.bind(this))
+
     this._loadData()
   }
 
@@ -108,4 +123,10 @@ var ProjectsScreen = GObject.registerClass({}, class ProjectsScreen extends St.B
       this._list.addItem(new ProjectCard(project, latestPipeline))
     })
   }
+
+  _onDestroy () {
+    if (this._settingsChangedId) {
+      Settings.disconnect(this._settingsChangedId)
+    }
+  }
 })

gitlab-extension@infinicode.de/components/searchBar/searchBar.js

@@ -78,7 +78,7 @@ var SearchBar = GObject.registerClass({
   }
 
   _createButtonBox () {
-    let buttonBox = new St.BoxLayout({
+    const buttonBox = new St.BoxLayout({
       style_class: 'button-box',
       x_align: St.Align.END
     })