adjust argument checking for > and >=

If both arguments to `>` or `>=` are not real numbers, complain about
the earlier argument. There's generally no guarantee about the order
that arguments will be checked, but most checks are left-to-right, so
it becomes expected by users. The checks for `>` and `>=` were
backward only because they're implemented using `$<` and `$<=`. This
small adjustment to error reporting should have minimal overall
impact, since the adjustment is only only in the error case.

Author: mflatt

mats/5_3.ms

@@ -1137,6 +1137,7 @@
     (error? (< 3.4+0.0i 3.5))
     (error? (< 3.2 3.4+0.0i))
     (error? (< 3.2 3.3 3.4+0.0i))
+    (error? (< 1.0+0.0i 0.0+2.0i))
     (not (< 3 3))
     (< 3 4)
     (not (< -3 -3))
@@ -1197,6 +1198,7 @@
     (error? (<= 3.4+0.0i 3.5))
     (error? (<= 3.2 3.4+0.0i))
     (error? (<= 3.2 3.3 3.4+0.0i))
+    (error? (<= 1.0+0.0i 0.0+2.0i))
     (<= 3 3)
     (<= 3 4)
     (<= -3 -3)
@@ -1256,6 +1258,7 @@
     (error? (> 3.4+0.0i 3.5))
     (error? (> 3.2 3.4+0.0i))
     (error? (> 3.2 3.3 3.4+0.0i))
+    (error? (> 1.0+0.0i 0.0+2.0i))
     (not (> 3 3))
     (not (> 3 4))
     (not (> -3 -3))
@@ -1315,6 +1318,7 @@
     (error? (>= 3.4+0.0i 3.5))
     (error? (>= 3.2 3.4+0.0i))
     (error? (>= 3.2 3.3 3.4+0.0i))
+    (error? (>= 1.0+0.0i 0.0+2.0i))
     (>= 3 3)
     (not (>= 3 4))
     (>= -3 -3)
@@ -1417,6 +1421,7 @@
     (error? (r6rs:< 'a 3 4))
     (error? (r6rs:< 4 'a 3))
     (error? (r6rs:< 3 5 'a 4))
+    (error? (r6rs:< 1.0+0.0i 0.0+2.0i))
     (not (r6rs:< 3 3))
     (r6rs:< 3 4)
     (not (r6rs:< -3 -3))
@@ -1467,6 +1472,7 @@
     (error? (r6rs:<= 'a 3 4))
     (error? (r6rs:<= 4 'a 3))
     (error? (r6rs:<= 3 5 'a 4))
+    (error? (r6rs:<= 1.0+0.0i 0.0+2.0i))
     (r6rs:<= 3 3)
     (r6rs:<= 3 4)
     (r6rs:<= -3 -3)
@@ -1517,6 +1523,7 @@
     (error? (r6rs:> 'a 3 4))
     (error? (r6rs:> 4 'a 3))
     (error? (r6rs:> 3 5 'a 4))
+    (error? (r6rs:> 1.0+0.0i 0.0+2.0i))
     (not (r6rs:> 3 3))
     (not (r6rs:> 3 4))
     (not (r6rs:> -3 -3))
@@ -1567,6 +1574,7 @@
     (error? (r6rs:>= 'a 3 4))
     (error? (r6rs:>= 4 'a 3))
     (error? (r6rs:>= 3 5 'a 4))
+    (error? (r6rs:>= 1.0+0.0i 0.0+2.0i))
     (r6rs:>= 3 3)
     (not (r6rs:>= 3 4))
     (r6rs:>= -3 -3)

mats/root-experr-compile-0-f-f-f

@@ -1030,6 +1030,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat <: "<: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat <: "<: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat <: "<: 3.4+0.0i is not a real number".
+5_3.mo:Expected error in mat <: "<: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat <: "<: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat <: "<: 2+1i is not a real number".
 5_3.mo:Expected error in mat <: "<: 3+1i is not a real number".
@@ -1050,6 +1051,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat <=: "<=: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat <=: "<=: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat <=: "<=: 3.4+0.0i is not a real number".
+5_3.mo:Expected error in mat <=: "<=: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat <=: "<=: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat <=: "<=: 2+1i is not a real number".
 5_3.mo:Expected error in mat <=: "<=: 3+1i is not a real number".
@@ -1070,6 +1072,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat >: ">: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat >: ">: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat >: ">: 3.4+0.0i is not a real number".
+5_3.mo:Expected error in mat >: ">: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat >: ">: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat >: ">: 2+1i is not a real number".
 5_3.mo:Expected error in mat >: ">: 3+1i is not a real number".
@@ -1090,6 +1093,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat >=: ">=: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat >=: ">=: 3.4+0.0i is not a real number".
 5_3.mo:Expected error in mat >=: ">=: 3.4+0.0i is not a real number".
+5_3.mo:Expected error in mat >=: ">=: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat >=: ">=: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat >=: ">=: 2+1i is not a real number".
 5_3.mo:Expected error in mat >=: ">=: 3+1i is not a real number".
@@ -1111,6 +1115,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat r6rs:<: "<: a is not a real number".
 5_3.mo:Expected error in mat r6rs:<: "<: a is not a real number".
 5_3.mo:Expected error in mat r6rs:<: "<: a is not a real number".
+5_3.mo:Expected error in mat r6rs:<: "<: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:<: "<: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:<: "<: 2+1i is not a real number".
 5_3.mo:Expected error in mat r6rs:<: "<: 3+1i is not a real number".
@@ -1123,6 +1128,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat r6rs:<=: "<=: a is not a real number".
 5_3.mo:Expected error in mat r6rs:<=: "<=: a is not a real number".
 5_3.mo:Expected error in mat r6rs:<=: "<=: a is not a real number".
+5_3.mo:Expected error in mat r6rs:<=: "<=: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:<=: "<=: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:<=: "<=: 2+1i is not a real number".
 5_3.mo:Expected error in mat r6rs:<=: "<=: 3+1i is not a real number".
@@ -1135,6 +1141,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat r6rs:>: ">: a is not a real number".
 5_3.mo:Expected error in mat r6rs:>: ">: a is not a real number".
 5_3.mo:Expected error in mat r6rs:>: ">: a is not a real number".
+5_3.mo:Expected error in mat r6rs:>: ">: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:>: ">: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:>: ">: 2+1i is not a real number".
 5_3.mo:Expected error in mat r6rs:>: ">: 3+1i is not a real number".
@@ -1147,6 +1154,7 @@ primvars.mo:Expected error in mat trace-output-port: "trace-output-port: #<input
 5_3.mo:Expected error in mat r6rs:>=: ">=: a is not a real number".
 5_3.mo:Expected error in mat r6rs:>=: ">=: a is not a real number".
 5_3.mo:Expected error in mat r6rs:>=: ">=: a is not a real number".
+5_3.mo:Expected error in mat r6rs:>=: ">=: 1.0+0.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:>=: ">=: 2.0+1.0i is not a real number".
 5_3.mo:Expected error in mat r6rs:>=: ">=: 2+1i is not a real number".
 5_3.mo:Expected error in mat r6rs:>=: ">=: 3+1i is not a real number".

s/5_3.ss

@@ -2379,7 +2379,12 @@
              [(fixnum?) (if (fixnum-floatable-wlop? y) (fl< x (fixnum->flonum y)) (exact-inexact-compare? > y x))]
              [(bignum? ratnum?) (exact-inexact-compare? > y x)]
              [else (nonreal-error who y)])]
-         [else (nonreal-error who x)])))
+         [else (when (and (eq? who '>)
+                          ;; arguments were reversed; call in other order to
+                          ;; check original first argument first
+                          (not (real? y)))
+                 (nonreal-error who y))
+               (nonreal-error who x)])))
 
 (set! $<=
    (lambda (who x y)
@@ -2415,7 +2420,12 @@
              [(fixnum?) (if (fixnum-floatable-wlop? y) (fl<= x (fixnum->flonum y)) (exact-inexact-compare? >= y x))]
              [(bignum? ratnum?) (exact-inexact-compare? >= y x)]
              [else (nonreal-error who y)])]
-         [else (nonreal-error who x)])))
+         [else (when (and (eq? who '>=)
+                          ;; arguments were reversed; call in other order to
+                          ;; check original first argument first
+                          (not (real? y)))
+                 (nonreal-error who y))
+               (nonreal-error who x)])))
 
 (set! $+
   (lambda (who x y)